You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2011/01/12 02:34:48 UTC

[jira] Created: (COUCHDB-1024) New replicator implementation

New replicator implementation
-----------------------------

                 Key: COUCHDB-1024
                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
             Project: CouchDB
          Issue Type: Improvement
          Components: Replication
            Reporter: Filipe Manana
            Assignee: Adam Kocoloski
             Fix For: 1.2


As recently posted to the development mailing:

http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E

( shortened URL http://s.apache.org/KsY )

There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.

@Adam, do you think you can give it a review?

The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator

Would be equally happy if others are able and willing to review and test as well.

Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Resolved: (COUCHDB-1024) New replicator implementation

Posted by Damien Katz <da...@apache.org>.
Awesome work Filipe!

-Damien



On 2/16/11 12:45 PM, "Filipe David Manana" <fd...@apache.org> wrote:

>Thanks Paul :)
>
>On Wed, Feb 16, 2011 at 8:43 PM, Paul Davis <pa...@gmail.com>
>wrote:
>> Awesome work Filipe!
>>
>> On Wed, Feb 16, 2011 at 3:18 PM, Filipe Manana (JIRA) <ji...@apache.org>
>>wrote:
>>>
>>>     [ 
>>>https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.ji
>>>ra.plugin.system.issuetabpanels:all-tabpanel ]
>>>
>>> Filipe Manana resolved COUCHDB-1024.
>>> ------------------------------------
>>>
>>>    Resolution: Fixed
>>>
>>> Applied to trunk
>>>
>>>> New replicator implementation
>>>> -----------------------------
>>>>
>>>>                 Key: COUCHDB-1024
>>>>                 URL:
>>>>https://issues.apache.org/jira/browse/COUCHDB-1024
>>>>             Project: CouchDB
>>>>          Issue Type: Improvement
>>>>          Components: Replication
>>>>            Reporter: Filipe Manana
>>>>            Assignee: Filipe Manana
>>>>             Fix For: 1.2
>>>>
>>>>
>>>> As recently posted to the development mailing:
>>>> 
>>>>http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAAN
>>>>LkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
>>>> ( shortened URL http://s.apache.org/KsY )
>>>> There's a new replicator implementation. I won't explain here all the
>>>>details since it's already done by that mail sent to the development
>>>>list.
>>>> @Adam, do you think you can give it a review?
>>>> The full diff is at:
>>>>https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
>>>> Would be equally happy if others are able and willing to review and
>>>>test as well.
>>>> Also take note that some pull replications of databases with
>>>>attachments created by prior CouchDB releases (including 1.0.1, but
>>>>excluding the soon to be released 1.0.2) may hang forever. This is
>>>>fixed by applying the patch for COUCHDB-1022 to the source server.
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> -
>>> For more information on JIRA, see:
>>>http://www.atlassian.com/software/jira
>>>
>>>
>>>
>>
>
>
>
>-- 
>Filipe David Manana,
>fdmanana@gmail.com, fdmanana@apache.org
>
>"Reasonable men adapt themselves to the world.
> Unreasonable men adapt the world to themselves.
> That's why all progress depends on unreasonable men."



Re: [jira] Resolved: (COUCHDB-1024) New replicator implementation

Posted by Filipe David Manana <fd...@apache.org>.
Thanks Paul :)

On Wed, Feb 16, 2011 at 8:43 PM, Paul Davis <pa...@gmail.com> wrote:
> Awesome work Filipe!
>
> On Wed, Feb 16, 2011 at 3:18 PM, Filipe Manana (JIRA) <ji...@apache.org> wrote:
>>
>>     [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Filipe Manana resolved COUCHDB-1024.
>> ------------------------------------
>>
>>    Resolution: Fixed
>>
>> Applied to trunk
>>
>>> New replicator implementation
>>> -----------------------------
>>>
>>>                 Key: COUCHDB-1024
>>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>>>             Project: CouchDB
>>>          Issue Type: Improvement
>>>          Components: Replication
>>>            Reporter: Filipe Manana
>>>            Assignee: Filipe Manana
>>>             Fix For: 1.2
>>>
>>>
>>> As recently posted to the development mailing:
>>> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
>>> ( shortened URL http://s.apache.org/KsY )
>>> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
>>> @Adam, do you think you can give it a review?
>>> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
>>> Would be equally happy if others are able and willing to review and test as well.
>>> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>



-- 
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

Re: [jira] Resolved: (COUCHDB-1024) New replicator implementation

Posted by David Coallier <da...@php.net>.
Definitely :) Looks very very promising!

On 16 February 2011 20:43, Paul Davis <pa...@gmail.com> wrote:
> Awesome work Filipe!
>
> On Wed, Feb 16, 2011 at 3:18 PM, Filipe Manana (JIRA) <ji...@apache.org> wrote:
>>
>>     [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Filipe Manana resolved COUCHDB-1024.
>> ------------------------------------
>>
>>    Resolution: Fixed
>>
>> Applied to trunk
>>
>>> New replicator implementation
>>> -----------------------------
>>>
>>>                 Key: COUCHDB-1024
>>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>>>             Project: CouchDB
>>>          Issue Type: Improvement
>>>          Components: Replication
>>>            Reporter: Filipe Manana
>>>            Assignee: Filipe Manana
>>>             Fix For: 1.2
>>>
>>>
>>> As recently posted to the development mailing:
>>> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
>>> ( shortened URL http://s.apache.org/KsY )
>>> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
>>> @Adam, do you think you can give it a review?
>>> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
>>> Would be equally happy if others are able and willing to review and test as well.
>>> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>>
>



-- 
David Coallier

Re: [jira] Resolved: (COUCHDB-1024) New replicator implementation

Posted by Paul Davis <pa...@gmail.com>.
Awesome work Filipe!

On Wed, Feb 16, 2011 at 3:18 PM, Filipe Manana (JIRA) <ji...@apache.org> wrote:
>
>     [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Filipe Manana resolved COUCHDB-1024.
> ------------------------------------
>
>    Resolution: Fixed
>
> Applied to trunk
>
>> New replicator implementation
>> -----------------------------
>>
>>                 Key: COUCHDB-1024
>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>>             Project: CouchDB
>>          Issue Type: Improvement
>>          Components: Replication
>>            Reporter: Filipe Manana
>>            Assignee: Filipe Manana
>>             Fix For: 1.2
>>
>>
>> As recently posted to the development mailing:
>> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
>> ( shortened URL http://s.apache.org/KsY )
>> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
>> @Adam, do you think you can give it a review?
>> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
>> Would be equally happy if others are able and willing to review and test as well.
>> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.
>
> --
> This message is automatically generated by JIRA.
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990758#comment-12990758 ] 

Randall Leeds commented on COUCHDB-1024:
----------------------------------------

I'm looking at the new_replicator branch.
I see a problem in couch_replicator_utils.erl that breaks backwards compatibility with existing replication checkpoints.

parse_rep_db/2 converts a remote endpoint to #httpdb.
In the old code, a bare URL in source or target would result in {remote, Url, []} from get_rep_endpoint/1.
In the new code, a bare URL becomes #httpdb{url=Url, headers = [], oauth = nil}. get_rep_endpoint/1 in this case gives {remote, Url, [], nil}.
This term is part of the md5 sum to identify the replication and the checkpoint document.

We can convert everything to the new format, but you should use the code I wrote for couch_rep for finding and migrating old checkpoints.

This is also a good time to suggest that we extract the meaningful information from UserCtx in the local case instead of using the whole record. Otherwise, changes to the #user_ctx record break checkpoints in a way which is not obvious. I just ran into this problem during upgrade from 0.10.2 to 1.0.2.

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Rachel Willmer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990732#comment-12990732 ] 

Rachel Willmer commented on COUCHDB-1024:
-----------------------------------------

I'd like to discuss/review the test framework for replication, specifically for master-master scenarios. It might be useful to discuss what you currently do w.r.t. test scenarios, compared to our real-world setups to see whether we can either add some extra stress to the existing test scenarios; or find some more edge cases worth testing.

How about an offline discussion about this? and then we can report back.

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990771#comment-12990771 ] 

Paul Joseph Davis commented on COUCHDB-1024:
--------------------------------------------

Do it!

http://www.youtube.com/watch?v=lmUZGdi7Ty4

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Randall Leeds (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990805#comment-12990805 ] 

Randall Leeds commented on COUCHDB-1024:
----------------------------------------

I think it is incompatible, but not for the reason I said.

get_rep_endpoint converts from #httpdb{} to {remote, Url, Headers} or {remote, Url, Headers, OAuthList}.

But the latest code you just linked adds default headers:

https://github.com/fdmanana/couchdb/blob/trunk_new_replicator/src/couchdb/couch_replicator_utils.erl#L206

which means we get {remote, Url, [{"Accept", "application/json"}, {"User-Agent", "CouchDB/" ++ couch_server:get_version()}]}

compare to

https://github.com/apache/couchdb/blob/1.0.x/src/couchdb/couch_rep.erl#L524

{remote, Url, []}

Also. If we use default headers there that include a different user agent it means we *guarantee* we break checkpoints on every version upgrade. No?

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991275#comment-12991275 ] 

Filipe Manana commented on COUCHDB-1024:
----------------------------------------

Randall,

You're right about that last one. It uses the default headers as part of the input to calculate the replication ID. The User-Agent header, which describes the CouchDB version, would imply replication ID incompatibility between different versions.

Fixed, https://github.com/fdmanana/couchdb/commit/0685d4100b21406ee54ca8fccfc93e796fd9dd6d



> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (COUCHDB-1024) New replicator implementation

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Kocoloski reassigned COUCHDB-1024:
---------------------------------------

    Assignee: Filipe Manana  (was: Adam Kocoloski)

Hi Filipe, I've done a detailed review of the modifications to existing modules and a somewhat more cursory review of the new replicator modules.  We've discussed a couple of small changes and you've implemented them.  I think it's time for this code to land in trunk :D

One future improvement that we talked briefly about using immediate commits in the doc copier.  This would remove the need to explicitly call _ensure_full_commit on the target and clean up the code a bit.  The replicator's design should allow it to automatically overcome any additional per-request latency through concurrency and batch loading.

Awesome work!

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12990794#comment-12990794 ] 

Filipe Manana commented on COUCHDB-1024:
----------------------------------------

First of all, thanks everyone for the reviews and +1 votes. This is really important and a major change to add.

Randall, I don't think there is any incompatibility. The new replicator still uses tuples like {remote, Url, []} for calculating the replication IDs. Look at:

https://github.com/fdmanana/couchdb/blob/trunk_new_replicator/src/couchdb/couch_replicator_utils.erl#L122

and

https://github.com/fdmanana/couchdb/blob/trunk_new_replicator/src/couchdb/couch_replicator_utils.erl#L168

get_rep_endoint converts from #httpdb{} to {remote, Url, OAuthList}

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (COUCHDB-1024) New replicator implementation

Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Filipe Manana resolved COUCHDB-1024.
------------------------------------

    Resolution: Fixed

Applied to trunk

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COUCHDB-1024) New replicator implementation

Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COUCHDB-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980492#action_12980492 ] 

Adam Kocoloski commented on COUCHDB-1024:
-----------------------------------------

Thanks Filipe, will review.  Very happy to see this work landing!

> New replicator implementation
> -----------------------------
>
>                 Key: COUCHDB-1024
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1024
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Filipe Manana
>            Assignee: Adam Kocoloski
>             Fix For: 1.2
>
>
> As recently posted to the development mailing:
> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201101.mbox/%3CAANLkTi=NOsVDRUdYHiUGxQCjDXTNGNMOhPm9Bx=rS5ny@mail.gmail.com%3E
> ( shortened URL http://s.apache.org/KsY )
> There's a new replicator implementation. I won't explain here all the details since it's already done by that mail sent to the development list.
> @Adam, do you think you can give it a review?
> The full diff is at:  https://github.com/fdmanana/couchdb/compare/trunk_new_replicator
> Would be equally happy if others are able and willing to review and test as well.
> Also take note that some pull replications of databases with attachments created by prior CouchDB releases (including 1.0.1, but excluding the soon to be released 1.0.2) may hang forever. This is fixed by applying the patch for COUCHDB-1022 to the source server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.