You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/08/19 12:58:55 UTC
Review Request 13643: Unplug the nic when there are no ips set on the
interface
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13643/
-----------------------------------------------------------
Review request for cloudstack, anthony xu, Abhinandan Prateek, and Murali Reddy.
Repository: cloudstack-git
Description
-------
Unplugging the public nic on the VR when there are no ips set on the interface.
This issue of not reusing the public nic is present in the xen and mvm.
For vmware the nic got reused.
Diffs
-----
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 1fb86e0
patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh ae2d7e4
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 9104504
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 338e741
Diff: https://reviews.apache.org/r/13643/diff/
Testing
-------
Tested in xen and kvm.
Thanks,
Jayapal Reddy
Re: Review Request 13643: Unplug the nic when there are no ips set on the
interface
Posted by anthony xu <an...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13643/#review25308
-----------------------------------------------------------
Ship it!
Ship It!
- anthony xu
On Aug. 19, 2013, 10:58 a.m., Jayapal Reddy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13643/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 10:58 a.m.)
>
>
> Review request for cloudstack, anthony xu, Abhinandan Prateek, and Murali Reddy.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Unplugging the public nic on the VR when there are no ips set on the interface.
> This issue of not reusing the public nic is present in the xen and mvm.
>
> For vmware the nic got reused.
>
>
> Diffs
> -----
>
> core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 1fb86e0
> patches/systemvm/debian/config/opt/cloud/bin/ipassoc.sh ae2d7e4
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 9104504
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 338e741
>
> Diff: https://reviews.apache.org/r/13643/diff/
>
>
> Testing
> -------
>
> Tested in xen and kvm.
>
>
> Thanks,
>
> Jayapal Reddy
>
>