You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 12:02:12 UTC

[GitHub] [spark] kyoty opened a new pull request #32187: [SPARK-35087] Some columns in table ` Aggregated Metrics by Executor` of stage-detail page shows incorrectly.

kyoty opened a new pull request #32187:
URL: https://github.com/apache/spark/pull/32187


   ### What changes were proposed in this pull request?
   
    columns like 'Shuffle Read Size / Records', 'Output Size/ Records' etc  in table ` Aggregated Metrics by Executor` of stage-detail page should be sorted as numerical-order instead of lexicographical-order.
   
   ### Why are the changes needed?
   buf fix,the sorting style should be consistentbetween different columns
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Only JS was modified, and the manual test result works well.
   
   **before modified:**
   ![sort-result-incorrent](https://user-images.githubusercontent.com/52202080/114865055-565ed980-9e24-11eb-97ff-bd1769d3848b.png)
   
   **after modified:**
   
   ![sort-result-corrent](https://user-images.githubusercontent.com/52202080/114865187-7c847980-9e24-11eb-9fbc-39ee224726d6.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32187: [SPARK-35087] Some columns in table ` Aggregated Metrics by Executor` of stage-detail page shows incorrectly.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32187:
URL: https://github.com/apache/spark/pull/32187#issuecomment-820371902


   @kyoty, I think your branch is not synced with the latest master branch in Apache Spark. Can you rebase your branch to the latest `master` branch in Apache Spark?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] kyoty closed pull request #32187: [SPARK-35087] Some columns in table ` Aggregated Metrics by Executor` of stage-detail page shows incorrectly.

Posted by GitBox <gi...@apache.org>.
kyoty closed pull request #32187:
URL: https://github.com/apache/spark/pull/32187


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] kyoty commented on pull request #32187: [SPARK-35087] Some columns in table ` Aggregated Metrics by Executor` of stage-detail page shows incorrectly.

Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32187:
URL: https://github.com/apache/spark/pull/32187#issuecomment-820376659


   thanks @HyukjinKwon, I'll try to rebase my branch first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org