You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/11 03:07:26 UTC

[GitHub] [skywalking] kezhenxu94 opened a new issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

kezhenxu94 opened a new issue #7896:
URL: https://github.com/apache/skywalking/issues/7896


   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   This feature allows people to reuse the `verify.cases` that can be shared between many similar cases.
   
   ## Reuse `verify.cases`
   
   We can add a configuration item `include` under `verify.cases`, people can extract the common `verify.case` snippets into a separate file and reuse them via `include`.
   
   ```yaml
   # setup:
   # trigger:
   verify:
     retry:
       count: 200
       interval: 5s
     cases:
       - include: simple-case.yaml
   ```
   
   ```yaml
   # simple-case.yaml
   cases:
     - query: swctl svc ls
       expected: expected/services.yaml
     # .....
   ```
   
   
   ### Use case
   
   We have many cases that share the same verifications and setup scripts. For example, the `auth`, `jdk`, `mtls` and `ssl` in main repo share the same verification cases but we need to duplicate the codes. https://github.com/apache/skywalking-java/pull/42#issuecomment-932974220 is a similar feature request to share the code snippets, I think if we share the `verify.cases`, others like `setup`, `trigger` can be tolerable because they are short enough. 
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7896:
URL: https://github.com/apache/skywalking/issues/7896#issuecomment-939674567


   > BTW `include` should be a list, right? We may need to split the verification into different files for reuse.
   
   Not necessarily, `include` can occur multiple times, so you can combine as many files as you want, reason is here https://github.com/apache/skywalking-infra-e2e/pull/53#discussion_r725780195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7896:
URL: https://github.com/apache/skywalking/issues/7896#issuecomment-939641288


   Good proposal. I can see we copied these repeatedly already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 closed issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7896:
URL: https://github.com/apache/skywalking/issues/7896


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7896:
URL: https://github.com/apache/skywalking/issues/7896#issuecomment-939651577


   BTW `include` should be a list, right? We may need to split the verification into different files for reuse.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mrproliu commented on issue #7896: [INFRA E2E][Feature] allow reusing the `verify.cases`

Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #7896:
URL: https://github.com/apache/skywalking/issues/7896#issuecomment-939653460


   > BTW `include` should be a list, right? We may need to split the verification into different files for reuse.
   
   I think it makes sense to me. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org