You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/11 11:24:39 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #13115: [FLINK-18219][runtime] Added OOM-enrichment for main method call in PackagedProgram.
tillrohrmann commented on a change in pull request #13115:
URL: https://github.com/apache/flink/pull/13115#discussion_r468508047
##########
File path: flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java
##########
@@ -293,7 +294,7 @@ private static void callMainMethod(Class<?> entryClass, String[] args) throws Pr
} catch (InvocationTargetException e) {
Throwable exceptionInMethod = e.getTargetException();
if (exceptionInMethod instanceof Error) {
- throw (Error) exceptionInMethod;
+ throw (Error) ClusterEntryPointExceptionUtils.tryEnrichClusterEntryPointError(exceptionInMethod);
Review comment:
I think the `PackagedProgram` is not the best place to call the enrichment method because this class can also be used on the client side when generating a `JobGraph` which is later submitted to the cluster. I think either the `JarRunHandler` and the `JarPlanHandler` or even the `AbstractHandler` might be a better place for the enrichment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org