You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "EugeneTorap (via GitHub)" <gi...@apache.org> on 2023/05/12 06:28:43 UTC
[GitHub] [superset] EugeneTorap opened a new pull request, #24033: chore: Update mypy and fix stubs issue
EugeneTorap opened a new pull request, #24033:
URL: https://github.com/apache/superset/pull/24033
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #24033: chore: Update mypy and fix stubs issue
Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #24033:
URL: https://github.com/apache/superset/pull/24033#discussion_r1191972803
##########
superset/embedded/view.py:
##########
@@ -55,6 +55,8 @@ def embedded(
if not embedded:
abort(404)
+ assert embedded is not None
Review Comment:
Mypy doc:
> You can often work around these errors by using assert isinstance(obj, ClassName) or assert obj is not None to tell mypy that you know that the type is more specific than what mypy thinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24033: chore: Update mypy and fix stubs issue
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24033:
URL: https://github.com/apache/superset/pull/24033#issuecomment-1545248299
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24033](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ee2ed7) into [master](https://app.codecov.io/gh/apache/superset/commit/7fe0ca12c0ae24c9b2546118e9ebdb94a9e3a22d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fe0ca1) will **decrease** coverage by `11.38%`.
> The diff coverage is `52.38%`.
> :exclamation: Current head 4ee2ed7 differs from pull request most recent head 10d5f95. Consider uploading reports for the commit 10d5f95 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24033 +/- ##
===========================================
- Coverage 68.21% 56.84% -11.38%
===========================================
Files 1941 1941
Lines 75259 75261 +2
Branches 8168 8168
===========================================
- Hits 51341 42782 -8559
- Misses 21829 30390 +8561
Partials 2089 2089
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.10% <33.33%> (-0.01%)` | :arrow_down: |
| python | `59.31% <52.38%> (-23.48%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.05% <42.85%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `50.65% <ø> (-35.20%)` | :arrow_down: |
| [superset/dashboards/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `51.40% <ø> (-41.18%)` | :arrow_down: |
| [superset/databases/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `51.23% <ø> (-40.35%)` | :arrow_down: |
| [superset/datasets/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `46.90% <ø> (-41.10%)` | :arrow_down: |
| [superset/embedded/view.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZW1iZWRkZWQvdmlldy5weQ==) | `48.48% <0.00%> (-42.15%)` | :arrow_down: |
| [superset/extensions/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy9fX2luaXRfXy5weQ==) | `98.86% <0.00%> (ø)` | |
| [superset/importexport/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW1wb3J0ZXhwb3J0L2FwaS5weQ==) | `100.00% <ø> (ø)` | |
| [superset/initialization/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `91.43% <0.00%> (ø)` | |
| [superset/queries/saved\_queries/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==) | `59.66% <ø> (-32.78%)` | :arrow_down: |
| [superset/sqllab/api.py](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvc3FsbGFiL2FwaS5weQ==) | `79.82% <ø> (-20.18%)` | :arrow_down: |
| ... and [9 more](https://app.codecov.io/gh/apache/superset/pull/24033?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [296 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24033/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24033: chore: Update mypy and fix stubs issue
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24033:
URL: https://github.com/apache/superset/pull/24033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org