You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@taverna.apache.org by ia...@apache.org on 2015/06/15 12:43:04 UTC

[09/15] incubator-taverna-mobile git commit: fixed workflow not downloading bug

fixed workflow not downloading bug


Project: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/commit/313864fa
Tree: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/tree/313864fa
Diff: http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/diff/313864fa

Branch: refs/heads/master
Commit: 313864faf0ef0f07fd61fc307d99530912e7483a
Parents: c32d847
Author: larrytech7 <la...@gmail.com>
Authored: Sun Jun 14 00:02:12 2015 +0100
Committer: larrytech7 <la...@gmail.com>
Committed: Sun Jun 14 00:02:12 2015 +0100

----------------------------------------------------------------------
 .../apache/taverna/mobile/adapters/WorkflowAdapter.java  |  8 +++++---
 .../taverna/mobile/fragments/WorkflowItemFragment.java   | 11 ++---------
 2 files changed, 7 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/313864fa/app/src/main/java/org/apache/taverna/mobile/adapters/WorkflowAdapter.java
----------------------------------------------------------------------
diff --git a/app/src/main/java/org/apache/taverna/mobile/adapters/WorkflowAdapter.java b/app/src/main/java/org/apache/taverna/mobile/adapters/WorkflowAdapter.java
index 7931899..f096eff 100644
--- a/app/src/main/java/org/apache/taverna/mobile/adapters/WorkflowAdapter.java
+++ b/app/src/main/java/org/apache/taverna/mobile/adapters/WorkflowAdapter.java
@@ -31,6 +31,7 @@ import android.net.Uri;
 import android.preference.PreferenceManager;
 import android.support.v7.widget.RecyclerView;
 import android.text.Html;
+import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
@@ -93,9 +94,10 @@ public class WorkflowAdapter extends RecyclerView.Adapter<WorkflowAdapter.ViewHo
 
                     String workflow_name = Uri.parse(wkflow_url).getLastPathSegment();
                     WorkflowDownloadManager dm = new WorkflowDownloadManager(c);
-                    dm.downloadWorkflow(new File(PreferenceManager
-                            .getDefaultSharedPreferences(c)
-                            .getString(DashboardMainActivity.APP_DIRECTORY_NAME, "/")+File.separator+workflow_name), wkflow_url);
+                    File destinationFile = new File(PreferenceManager.getDefaultSharedPreferences(c)
+                            .getString(DashboardMainActivity.APP_DIRECTORY_NAME, "/"));
+                    Log.i("Workflow Name ", destinationFile.getAbsolutePath());
+                    dm.downloadWorkflow(destinationFile, wkflow_url);
                 } catch(NullPointerException np){
                     np.printStackTrace();
                 }catch (IllegalArgumentException ill){

http://git-wip-us.apache.org/repos/asf/incubator-taverna-mobile/blob/313864fa/app/src/main/java/org/apache/taverna/mobile/fragments/WorkflowItemFragment.java
----------------------------------------------------------------------
diff --git a/app/src/main/java/org/apache/taverna/mobile/fragments/WorkflowItemFragment.java b/app/src/main/java/org/apache/taverna/mobile/fragments/WorkflowItemFragment.java
index 3bfb0a0..d31774c 100644
--- a/app/src/main/java/org/apache/taverna/mobile/fragments/WorkflowItemFragment.java
+++ b/app/src/main/java/org/apache/taverna/mobile/fragments/WorkflowItemFragment.java
@@ -61,7 +61,7 @@ import java.util.List;
  * Activities containing this fragment MUST implement the {@link org.apache.taverna.mobile.fragments.WorkflowItemFragment.OnWorkflowSelectedListener}
  * interface.
  */
-public class WorkflowItemFragment extends Fragment implements AdapterView.OnItemClickListener,android.app.LoaderManager.LoaderCallbacks<List<Workflow>> {
+public class WorkflowItemFragment extends Fragment implements android.app.LoaderManager.LoaderCallbacks<List<Workflow>> {
 
     // TODO: Rename parameter arguments, choose names that match
     // the fragment initialization parameters, e.g. ARG_ITEM_NUMBER
@@ -197,6 +197,7 @@ public class WorkflowItemFragment extends Fragment implements AdapterView.OnItem
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if(item.getTitle().equals("Refresh")){
+            getActivity().setProgressBarIndeterminateVisibility(true);
             getActivity().getLoaderManager().restartLoader(0, null, this);
             return true;
         }
@@ -209,14 +210,6 @@ public class WorkflowItemFragment extends Fragment implements AdapterView.OnItem
         mListener = null;
     }
 
-    @Override
-    public void onItemClick(AdapterView<?> parent, View view, int position, long id) {
-        if (null != mListener) {
-            // Notify the active callbacks interface (the activity, if the
-            // fragment is attached to one) that an item has been selected.
-            mListener.onWorkflowSelected(position);
-        }
-    }
     /**
      * The default content for this Fragment has a TextView that is shown when
      * the list is empty. If you would like to change the text, call this method