You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/06/25 00:14:21 UTC
[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3493
to review the following change.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
......................................................................
Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
This test was flaky because it was assuming that the order of entries in the
TServersDetail map matched the ordering of tablet servers in the minicluster's
tablet server vector. This is not always the case, so the assertions waiting
for nodes to crash sometimes timed out (since they were waiting on the wrong
nodes).
Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/3493/1
--
To view, visit http://gerrit.cloudera.org:8080/3493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1987/
--
To view, visit http://gerrit.cloudera.org:8080/3493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
......................................................................
Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
This test was flaky because it was assuming that the order of entries in the
TServersDetail map matched the ordering of tablet servers in the minicluster's
tablet server vector. This is not always the case, so the assertions waiting
for nodes to crash sometimes timed out (since they were waiting on the wrong
nodes).
Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Reviewed-on: http://gerrit.cloudera.org:8080/3493
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/raft_consensus-itest.cc
1 file changed, 12 insertions(+), 8 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/3493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
......................................................................
Patch Set 1:
Kind of hard to grep for this, but I'm doing a pass over flakies, so if we're doing this elsewhere and it causes flakiness, I'll see it.
--
To view, visit http://gerrit.cloudera.org:8080/3493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix flakiness of RaftConsensusITest.TestLogIOErrorIsFatal
......................................................................
Patch Set 1: Code-Review+2
Could you poke around and see if we repeat this antipattern in other integration tests?
--
To view, visit http://gerrit.cloudera.org:8080/3493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If62911f9517b60d82fac97bacd2ac01584be442f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No