You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/07 08:09:44 UTC

[GitHub] [incubator-kyuubi] link3280 edited a comment on pull request #1693: [KYUUBI #1681] Extend Flink ExecuteStatement to support more operations

link3280 edited a comment on pull request #1693:
URL: https://github.com/apache/incubator-kyuubi/pull/1693#issuecomment-1007203021


   There are two things worth noting in this PR: 
   
   -  I removed some classes in the `result` package to better align with Flink's TableResult. Please take a look if it's okay. cc @yanghua 
   - There's a bug in executing DML like `insert` statements. Looks like the session was closed prematurely. It may need more time to investigate. I've temporarily ignored the test for inserts and will make a follow-up PR to fix the problem. But I'm OK if we require to fix that before getting the PR merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org