You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/09 05:52:07 UTC
[GitHub] [rocketmq] EZLippi opened a new pull request #2790: fix: issue 2781 return all cluster
EZLippi opened a new pull request #2790:
URL: https://github.com/apache/rocketmq/pull/2790
**Make sure set the target branch to `develop`**
## What is the purpose of the change
fix issue #2781
## Brief changelog
return all cluster name for a topic
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin edited a comment on pull request #2790: [ISSUE# 2781] DefaultMQAdminExtImpl getTopicClusterList loss cluster info
Posted by GitBox <gi...@apache.org>.
RongtongJin edited a comment on pull request #2790:
URL: https://github.com/apache/rocketmq/pull/2790#issuecomment-817457658
It would be better if you could add UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2790: fix: issue 2781 return all cluster
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2790:
URL: https://github.com/apache/rocketmq/pull/2790#issuecomment-816432137
[](https://coveralls.io/builds/38668361)
Coverage decreased (-0.08%) to 51.851% when pulling **1e1fad80b733e93b1a60f6dad1124f9fbd699cf5 on EZLippi:feature/issue2781** into **7680063f89a2aa5ae003f5d19ebd3343e828b94f on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2790: [ISSUE# 2781] DefaultMQAdminExtImpl getTopicClusterList loss cluster info
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2790:
URL: https://github.com/apache/rocketmq/pull/2790#issuecomment-817457658
It would be better if you can add UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org