You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/05/26 23:32:14 UTC
[GitHub] [incubator-mxnet] DominikaJedynak opened a new pull request, #21042: Fix for fc with sum when types are incompatible
DominikaJedynak opened a new pull request, #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042
## Description ##
This PR fixes the problem occurring when data_2, which is to be added to quantized fc output, happens to be all non-negative (and treated as u8) while fc output is s8. In this situation, data_2 will be rescaled to s8 as well to prevent truncation of fc output.
This change also prevents the situation when fc output is u8 and data_2 is s8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140339503
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1156087524
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1188871083
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1188870986
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140259003
@mxnet-bot run ci [centos-cpu, edge, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1181652083
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1139527285
Jenkins CI successfully triggered : [website, centos-gpu, centos-cpu, clang, unix-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1181942265
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1182828190
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1182828273
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1181652213
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1161970189
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140339497
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140415683
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140415673
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1181942373
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1156087608
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1158868535
Jenkins CI successfully triggered : [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1161970110
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1139527198
@mxnet-bot run ci [centos-gpu, centos-cpu, clang, unix-cpu, website]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1139143329
Hey @DominikaJedynak , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, website, windows-cpu, unix-cpu, unix-gpu, clang, miscellaneous, centos-gpu, sanity, windows-gpu, edge]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1140259033
Jenkins CI successfully triggered : [edge, unix-gpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1171332471
Jenkins CI successfully triggered : [unix-gpu, centos-cpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1171332342
@mxnet-bot run ci [centos-cpu, unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] DominikaJedynak commented on pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
DominikaJedynak commented on PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042#issuecomment-1158868430
@mxnet-bot run ci [unix-gpu]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych merged pull request #21042: [v1.x] Fix for fc with sum when types are incompatible
Posted by GitBox <gi...@apache.org>.
bgawrych merged PR #21042:
URL: https://github.com/apache/incubator-mxnet/pull/21042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org