You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-dev@httpd.apache.org by Stas Bekman <st...@stason.org> on 2001/08/07 07:42:04 UTC
CacheNegotiatedDocs patch
the server
% perl t/TEST httpd /home/stas/httpd-2.0/bin/httpd -run
won't start without this fix:
Index: perl-framework/t/conf/extra.conf.in
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/t/conf/extra.conf.in,v
retrieving revision 1.6
diff -u -r1.6 extra.conf.in
--- perl-framework/t/conf/extra.conf.in 2001/08/06 18:19:29 1.6
+++ perl-framework/t/conf/extra.conf.in 2001/08/07 05:40:46
@@ -30,7 +30,7 @@
AddHandler type-map .var
<IfModule mod_negotiation.c>
-CacheNegotiatedDocs
+CacheNegotiatedDocs On
<Directory @SERVERROOT@/htdocs/modules/negotiation/en>
Options +MultiViews
LanguagePriority en fr de fu
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
Re: CacheNegotiatedDocs patch
Posted by Ryan Bloom <rb...@covalent.net>.
On Tuesday 07 August 2001 08:02, Stas Bekman wrote:
> On Tue, 7 Aug 2001, Ryan Bloom wrote:
> > The problem is that all the tests are being written against 1.3, and
> > once they all succeed against 1.3, they are being tried against a 2.0
> > server. Unfortunately, the config files aren't always compatible, so
> > the error you are seeing is because this test only works on 1.3.
> > Doug just added a way to write a config file for both 1.3 and 2.0, and
> > have the test harness continue to work, so things like this can be
> > fixed quickly.
>
> OK, now I realize that this, in conjunction with your email to new-httpd.
>
> what we can do also is to use ifdefs in httpd.conf where the configuration
> sections aren't the same.
That's how Doug's latest patch works, but it required a way to add the -D to
the httpd line.
> So I shouldn't test it against 2.0 at this point. anyway, I hope that my
> other patches are still relevant :)
I would keep testing against 2.0, but realize that a failed test may very
well mean broken code, not a broken test.
Ryan
Re: CacheNegotiatedDocs patch
Posted by Stas Bekman <st...@stason.org>.
On Tue, 7 Aug 2001, Ryan Bloom wrote:
>
> The problem is that all the tests are being written against 1.3, and
> once they all succeed against 1.3, they are being tried against a 2.0
> server. Unfortunately, the config files aren't always compatible, so
> the error you are seeing is because this test only works on 1.3.
> Doug just added a way to write a config file for both 1.3 and 2.0, and
> have the test harness continue to work, so things like this can be
> fixed quickly.
OK, now I realize that this, in conjunction with your email to new-httpd.
what we can do also is to use ifdefs in httpd.conf where the configuration
sections aren't the same.
So I shouldn't test it against 2.0 at this point. anyway, I hope that my
other patches are still relevant :)
> Ryan
>
> On Monday 06 August 2001 22:42, Stas Bekman wrote:
> > the server
> >
> > % perl t/TEST httpd /home/stas/httpd-2.0/bin/httpd -run
> >
> > won't start without this fix:
> >
> > Index: perl-framework/t/conf/extra.conf.in
> > ===================================================================
> > RCS file: /home/cvs/httpd-test/perl-framework/t/conf/extra.conf.in,v
> > retrieving revision 1.6
> > diff -u -r1.6 extra.conf.in
> > --- perl-framework/t/conf/extra.conf.in 2001/08/06 18:19:29 1.6
> > +++ perl-framework/t/conf/extra.conf.in 2001/08/07 05:40:46
> > @@ -30,7 +30,7 @@
> > AddHandler type-map .var
> >
> > <IfModule mod_negotiation.c>
> > -CacheNegotiatedDocs
> > +CacheNegotiatedDocs On
> > <Directory @SERVERROOT@/htdocs/modules/negotiation/en>
> > Options +MultiViews
> > LanguagePriority en fr de fu
> >
> >
> > _____________________________________________________________________
> > Stas Bekman JAm_pH -- Just Another mod_perl Hacker
> > http://stason.org/ mod_perl Guide http://perl.apache.org/guide
> > mailto:stas@stason.org http://apachetoday.com http://eXtropia.com/
> > http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
>
> --
>
> _____________________________________________________________________________
> Ryan Bloom rbb@apache.org
> Covalent Technologies rbb@covalent.net
> -----------------------------------------------------------------------------
>
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
Re: CacheNegotiatedDocs patch
Posted by Ryan Bloom <rb...@covalent.net>.
The problem is that all the tests are being written against 1.3, and once they all
succeed against 1.3, they are being tried against a 2.0 server. Unfortunately,
the config files aren't always compatible, so the error you are seeing is because
this test only works on 1.3. Doug just added a way to write a config file for both
1.3 and 2.0, and have the test harness continue to work, so things like this can
be fixed quickly.
Ryan
On Monday 06 August 2001 22:42, Stas Bekman wrote:
> the server
>
> % perl t/TEST httpd /home/stas/httpd-2.0/bin/httpd -run
>
> won't start without this fix:
>
> Index: perl-framework/t/conf/extra.conf.in
> ===================================================================
> RCS file: /home/cvs/httpd-test/perl-framework/t/conf/extra.conf.in,v
> retrieving revision 1.6
> diff -u -r1.6 extra.conf.in
> --- perl-framework/t/conf/extra.conf.in 2001/08/06 18:19:29 1.6
> +++ perl-framework/t/conf/extra.conf.in 2001/08/07 05:40:46
> @@ -30,7 +30,7 @@
> AddHandler type-map .var
>
> <IfModule mod_negotiation.c>
> -CacheNegotiatedDocs
> +CacheNegotiatedDocs On
> <Directory @SERVERROOT@/htdocs/modules/negotiation/en>
> Options +MultiViews
> LanguagePriority en fr de fu
>
>
> _____________________________________________________________________
> Stas Bekman JAm_pH -- Just Another mod_perl Hacker
> http://stason.org/ mod_perl Guide http://perl.apache.org/guide
> mailto:stas@stason.org http://apachetoday.com http://eXtropia.com/
> http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
--
_____________________________________________________________________________
Ryan Bloom rbb@apache.org
Covalent Technologies rbb@covalent.net
-----------------------------------------------------------------------------