[GitHub] [iceberg] manisin commented on a diff in pull request #6740: Add application identifier for Snowflake JDBC driver

["manisin (via GitHub)" <gi...@apache.org>]

manisin commented on code in PR #6740:
URL: https://github.com/apache/iceberg/pull/6740#discussion_r1097808842


##########
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java:
##########
@@ -109,6 +110,10 @@ public void initialize(String name, Map<String, String> properties) {
               + " JDBC driver to your jars/packages",
           cnfe);
     }
+
+    // Populate application identifier in jdbc client
+    properties.put("application", APP_IDENTIFIER);

Review Comment:
   APP_ID property is not supported by Snowflake's jdbc driver, it requires application. Also as Daniel pointed out, application property does not uniquely point to each catalog usage but broadly identifies the partner app type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org