You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2012/03/01 01:01:15 UTC

svn commit: r1295348 - /qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java

Author: robbie
Date: Thu Mar  1 00:01:14 2012
New Revision: 1295348

URL: http://svn.apache.org/viewvc?rev=1295348&view=rev
Log:
QPID-3605: update test comments to reflect change in broker behaviour after the changes in this JIRA

Modified:
    qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java

Modified: qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java?rev=1295348&r1=1295347&r2=1295348&view=diff
==============================================================================
--- qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java (original)
+++ qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/persistent/NoLocalAfterRecoveryTest.java Thu Mar  1 00:01:14 2012
@@ -66,6 +66,8 @@ public class NoLocalAfterRecoveryTest ex
         // Check messages can be received as expected.
         connection.start();
 
+        //As the no-local subscriber was on the same connection the messages were
+        //published on, tit will receive no messages as they will be discarded on the broker
         List<Message> received = receiveMessage(noLocalSubscriber, SEND_COUNT);
         assertEquals("No Local Subscriber Received messages", 0, received.size());
 
@@ -77,8 +79,8 @@ public class NoLocalAfterRecoveryTest ex
         normalSubscriber.close();
         connection.close();
 
-        //We didn't receive the messages on the durable queue for the no-local subscriber
-        //so they are still on the broker. Restart the broker, prompting their recovery.
+        //Ensure the no-local subscribers messages were discarded by restarting the broker
+        //and reconnecting to the subscription to ensure they were not recovered.
         restartBroker();
 
         Connection connection2 = getConnection();



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org