[GitHub] spark pull request: [SPARK-12044] [SparkR] Fix usage of isnan, isn...

[felixcheung <gi...@git.apache.org>]

Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10037#discussion_r46224415
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -488,19 +488,35 @@ setMethod("initcap",
                 column(jc)
               })
     
    -#' isNaN
    +#' isnan
     #'
    -#' Return true iff the column is NaN.
    +#' Return true if the column is NaN.
     #'
    -#' @rdname isNaN
    -#' @name isNaN
    +#' @rdname isnan
    +#' @name isnan
     #' @family normal_funcs
     #' @export
    -#' @examples \dontrun{isNaN(df$c)}
    -setMethod("isNaN",
    +#' @examples \dontrun{isnan(df$c)}
    +setMethod("isnan",
    --- End diff --
    
    should this be called (or have an alias) `is.nan`?
    https://stat.ethz.ch/R-manual/R-devel/library/base/html/is.finite.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org