You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Owen Nichols <on...@pivotal.io> on 2019/10/28 07:46:31 UTC
[DISCUSS] review process documentation
Below is everything I could find addressing our current process around making and reviewing commits. If you’re a newer contributor, what topics are missing or unclear? If you’ve been a committer for a long time, does what’s in the wiki align with your understanding? Are there unwritten norms that might not be obvious to a new contributor? Thanks for taking a few minutes to review.
VOTEs:
June 2017: Require committers to use GitHub PR’s <https://lists.apache.org/thread.html/cc75b4743a3ecc4a7e278ba285d0d883822a7bc6079ad748f6a50d1e@%3Cdev.geode.apache.org%3E>
DISCUSSions:
Oct 2019: Blocking merge button in PR <https://lists.apache.org/thread.html/c3eb5c028cb3a4d76024f928a7a33c0311228f5dbbcaa86287bf5826@%3Cdev.geode.apache.org%3E>
Oct 2019: No-one is following our commit message formatting <https://lists.apache.org/thread.html/e2e42ab3b9687efb2baecd27bc17fe033437a9ee3f0b79636cb663f0@%3Cdev.geode.apache.org%3E>
Jun 2019: Adopting a coding standard <https://lists.apache.org/thread.html/5dc454470132cc59ed5e82db27fb359fd309adc7997cafc16f3b2dc7@%3Cdev.geode.apache.org%3E>
Sep 2018: Commit message formatting <https://lists.apache.org/thread.html/016ee4921908f2d1bdad4a28c15b2af93f4908aa898290db6f7c17b5@%3Cdev.geode.apache.org%3E>
Sep 2018: Test code style (particularly logging) <https://lists.apache.org/thread.html/86c94c9d3c734f29ecb7440de567f4b25832279f027e78c7f57ebd3e@%3Cdev.geode.apache.org%3E>
Sep 2018: Should we evaluate commit messages as part of PR review? <https://lists.apache.org/thread.html/016ee4921908f2d1bdad4a28c15b2af93f4908aa898290db6f7c17b5@%3Cdev.geode.apache.org%3E>
Feb 2017: JIRA guidelines <https://lists.apache.org/thread.html/bdd74ea6ad7f39ed27df1d3679340b5d2197aeff8f8c9c5b08c211d4@%3Cdev.geode.apache.org%3E>
WIKI pages:
Aug 2018: Criteria for Code Submissions <https://cwiki.apache.org/confluence/display/GEODE/Criteria+for+Code+Submissions?src=contextnavpagetreemode>
Sep 2017: Code contributions <https://cwiki.apache.org/confluence/display/GEODE/Code+contributions?src=contextnavpagetreemode>
Feb 2017: JIRA Guidelines <https://cwiki.apache.org/confluence/display/GEODE/JIRA+Guidelines?src=contextnavpagetreemode>
PR template:
Mar 2019: PULL_REQUEST_TEMPLATE.md <https://github.com/apache/geode/blob/develop/.github/PULL_REQUEST_TEMPLATE.md>