Re: [PR] [IGNITE-21999] Merge partition free-lists into one [ignite-3]

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #3615:
URL: https://github.com/apache/ignite-3/pull/3615#discussion_r1567461755


##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/FreeListImpl.java:
##########
@@ -126,10 +131,10 @@ protected Integer addRow(
                 long pageId,
                 long pageAddr,
                 PageIo iox,
-                T row,
+                Storable row,
                 int written
         ) throws IgniteInternalCheckedException {
-            AbstractDataPageIo<T> io = (AbstractDataPageIo<T>) iox;
+            AbstractDataPageIo<Storable> io = (AbstractDataPageIo<Storable>) iox;

Review Comment:
   I don't think that `DataPageIo` should be a parameterized type anymore



##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/freelist/FreeListImpl.java:
##########
@@ -91,7 +94,9 @@ public abstract class AbstractFreeList<T extends Storable> extends PagesList imp
 
     private final PageHandler<ReuseBag, Long> rmvRow;
 
-    private class WriteRowHandler implements PageHandler<T, Integer> {
+    private final IoStatisticsHolder statHolder;
+
+    private class WriteRowHandler implements PageHandler<Storable, Integer> {

Review Comment:
   Is there any chance of making these classes static? How much effort would that be?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org