You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jp...@apache.org on 2014/01/03 00:39:59 UTC

git commit: TS-2467: traffic_shell doesn't work with tcl 8.6, works with 8.5

Updated Branches:
  refs/heads/master d96ac78d0 -> 8901e65da


TS-2467: traffic_shell doesn't work with tcl 8.6, works with 8.5

Segfault in libtcl8.6.so when calling Tcl_SetMainLoop(Tcl_ReadlineMain).
If setting Tcl MainLoop, we should call Tcl_FindExecutable(NULL),
which fixes TCL 8.6 and should also work with older versions.


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/8901e65d
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/8901e65d
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/8901e65d

Branch: refs/heads/master
Commit: 8901e65da2c0affa742227b56d966f45e9d3e8a6
Parents: d96ac78
Author: Ben Aitchison <be...@meh.net.nz>
Authored: Thu Jan 2 15:37:40 2014 -0800
Committer: James Peach <jp...@apache.org>
Committed: Thu Jan 2 15:39:42 2014 -0800

----------------------------------------------------------------------
 CHANGES                            | 3 +++
 cmd/traffic_shell/traffic_shell.cc | 2 ++
 2 files changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8901e65d/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 7e4ae1e..2a0771c 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache Traffic Server 4.2.0
 
+  *) [TS-2467] traffic_shell doesn't work with tcl 8.6.
+   Author: Ben Aitchison <be...@meh.net.nz>
+
   *) [TS-1365] Add a new configuration option, proxy.config.net.poll_timeout,
    with the same behavior as the command line option --poll_timeout. Also
    adjust AIO scheduling to correlate to this setting, to avoid additional

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/8901e65d/cmd/traffic_shell/traffic_shell.cc
----------------------------------------------------------------------
diff --git a/cmd/traffic_shell/traffic_shell.cc b/cmd/traffic_shell/traffic_shell.cc
index 8da720a..29978c7 100644
--- a/cmd/traffic_shell/traffic_shell.cc
+++ b/cmd/traffic_shell/traffic_shell.cc
@@ -73,6 +73,8 @@ main(int argc, char *argv[])
     exit(0);
   }
 
+  Tcl_FindExecutable(argv[0]);
+
   // traffic_shell binary should use printf to display information onscreen
   CliDisplayPrintf = 1;