You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/20 17:36:22 UTC

[GitHub] [airflow] jedcunningham opened a new pull request #18384: Don't permanently add zip DAGs to `sys.path`

jedcunningham opened a new pull request #18384:
URL: https://github.com/apache/airflow/pull/18384


   Only leave the zip on `sys.path` while parsing that zip file, as we
   shouldn't assume parsing only happens in separate processes. For
   example, `resetdb` is used to run migrations, some of which parse
   the DAGs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #18384: Don't permanently add zip DAGs to ``sys.path``

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18384:
URL: https://github.com/apache/airflow/pull/18384


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18384: Don't permanently add zip DAGs to ``sys.path``

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18384:
URL: https://github.com/apache/airflow/pull/18384#issuecomment-923483588


   Do I get correctly  - that was causing the side-effect of failing KPO tests in some cases?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #18384: Don't permanently add zip DAGs to ``sys.path``

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18384:
URL: https://github.com/apache/airflow/pull/18384#issuecomment-923137293


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18384: Don't permanently add zip DAGs to ``sys.path``

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18384:
URL: https://github.com/apache/airflow/pull/18384#issuecomment-923609661


   PodGenerator, yeah. Some tests in `test_pod_generator.py` use `sys.path[0]` and expect it to have `cwd`:
   
   https://github.com/apache/airflow/blob/c686241f4ceb62d52e9bfa607822e4b7a3c76222/tests/kubernetes/test_pod_generator.py#L164
   
   However a couple migrations parse the DAGs and this was leaving the zip in spot 0 (in fact, it would be `[zip, zip, cwd, ...]`). You could force the issue every time using `--with-db-init`. Granted, the tests probably shouldn't rely on `sys.path[0]` being unmodified either, but this PR at least fixed the real issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org