You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by holdenk <gi...@git.apache.org> on 2017/07/21 06:05:47 UTC
[GitHub] spark pull request #18699: [SPARK-7146][ML][WIP] Expose the common params as...
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/18699
[SPARK-7146][ML][WIP] Expose the common params as a DeveloperAPI for other ML developers
## What changes were proposed in this pull request?
Expose the common params from Spark ML as a Developer API.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/holdenk/spark SPARK-7146-ml-shared-params-developer-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18699
----
commit 1ee22f02f13ed6dd46b89bfe6131bc754e3f4761
Author: Holden Karau <ho...@us.ibm.com>
Date: 2017-07-21T03:58:14Z
Expose the common params as a DeveloperAPI for other ML developers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83042/testReport)** for PR 18699 at commit [`a53c460`](https://github.com/apache/spark/commit/a53c460d0518ee64d51f2ca33b44125c01a2ffaf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18699
And updated after being called out in a talk and Spark Summit :p
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83042/testReport)** for PR 18699 at commit [`a53c460`](https://github.com/apache/spark/commit/a53c460d0518ee64d51f2ca33b44125c01a2ffaf).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #79825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79825/testReport)** for PR 18699 at commit [`1ee22f0`](https://github.com/apache/spark/commit/1ee22f02f13ed6dd46b89bfe6131bc754e3f4761).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` |trait Has$Name extends Params `
* `trait HasRegParam extends Params `
* `trait HasMaxIter extends Params `
* `trait HasFeaturesCol extends Params `
* `trait HasLabelCol extends Params `
* `trait HasPredictionCol extends Params `
* `trait HasRawPredictionCol extends Params `
* `trait HasProbabilityCol extends Params `
* `trait HasVarianceCol extends Params `
* `trait HasThreshold extends Params `
* `trait HasThresholds extends Params `
* `trait HasInputCol extends Params `
* `trait HasInputCols extends Params `
* `trait HasOutputCol extends Params `
* `trait HasCheckpointInterval extends Params `
* `trait HasFitIntercept extends Params `
* `trait HasHandleInvalid extends Params `
* `trait HasStandardization extends Params `
* `trait HasSeed extends Params `
* `trait HasElasticNetParam extends Params `
* `trait HasTol extends Params `
* `trait HasStepSize extends Params `
* `trait HasWeightCol extends Params `
* `trait HasSolver extends Params `
* `trait HasAggregationDepth extends Params `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83470/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18699
Merged into master
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18699: [SPARK-7146][ML] Expose the common params as a De...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18699
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79825/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #79825 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79825/testReport)** for PR 18699 at commit [`1ee22f0`](https://github.com/apache/spark/commit/1ee22f02f13ed6dd46b89bfe6131bc754e3f4761).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83042/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83470/testReport)** for PR 18699 at commit [`c6a7ddf`](https://github.com/apache/spark/commit/c6a7ddf6716c401caa1c250ba6e26fe6dd80a387).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18699
**[Test build #83470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83470/testReport)** for PR 18699 at commit [`c6a7ddf`](https://github.com/apache/spark/commit/c6a7ddf6716c401caa1c250ba6e26fe6dd80a387).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18699: [SPARK-7146][ML][WIP] Expose the common params as...
Posted by MLnick <gi...@git.apache.org>.
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/18699#discussion_r128696838
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala ---
@@ -177,9 +177,11 @@ private[shared] object SharedParamsCodeGen {
s"""
|/**
- | * Trait for shared param $name$defaultValueDoc.
+ | * Trait for shared param $name$defaultValueDoc. These traits may be changed or
--- End diff --
Should probably be "This trait"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML] Expose the common params as a Developer...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18699
Jenkins retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18699: [SPARK-7146][ML][WIP] Expose the common params as a Deve...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/18699
cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18699: [SPARK-7146][ML][WIP] Expose the common params as...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18699#discussion_r129447337
--- Diff: mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala ---
@@ -177,9 +177,11 @@ private[shared] object SharedParamsCodeGen {
s"""
|/**
- | * Trait for shared param $name$defaultValueDoc.
+ | * Trait for shared param $name$defaultValueDoc. These traits may be changed or
--- End diff --
Good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org