You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "lahwaacz (via GitHub)" <gi...@apache.org> on 2025/05/24 14:40:52 UTC
[PR] Fix CMake modules for finding external libraries [orc]
lahwaacz opened a new pull request, #2240:
URL: https://github.com/apache/orc/pull/2240
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
- allow finding header files in default paths - this is consistent with the logic for finding the library files
- replace undefined variables `${SNAPPY_LIB_NAME}` and `${LZ4_LIB_NAME}` with the actual names
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The CMake modules are broken. Building anything that depends on orc using cmake (e.g. Apache Arrow) does not work.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Better than the original files :smirk:
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "lahwaacz (via GitHub)" <gi...@apache.org>.
lahwaacz commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-2908563264
> Could you elaborate this?
Try to build the latest orc version and then arrow using the following cmake options (notice especially `-DARROW_DEPENDENCY_SOURCE=SYSTEM` and `-DARROW_ORC=ON`)
https://gitlab.archlinux.org/archlinux/packaging/packages/arrow/-/blob/main/PKGBUILD?ref_type=heads#L80-120
> I was thinking to remove these obsolete `FindXXX.cmake` files to use config mode of find_package so we don't have to maintain them.
The "config mode" is still looking for some `.cmake` file provided by the library you are finding. Many packages do that, including protobuf, snappy, and zstd, but some don't (e.g. lz4, zlib). But cmake also has its standard `FindZLIB` module so you don't have to reimplement your own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-2908302375
Thanks for creating this PR!
> The CMake modules are broken. Building anything that depends on orc using cmake (e.g. Apache Arrow) does not work.
Could you elaborate this? I was thinking to remove these obsolete `FindXXX.cmake` files to use config mode of find_package so we don't have to maintain them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "lahwaacz (via GitHub)" <gi...@apache.org>.
lahwaacz commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-2908780304
> * https://github.com/lz4/lz4/blob/dev/build/cmake/lz4Config.cmake.in
But if you install lz4 using a different build system (e.g. Arch Linux uses meson), the CMake integration files are not installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "lahwaacz (via GitHub)" <gi...@apache.org>.
lahwaacz closed pull request #2240: Fix CMake modules for finding external libraries
URL: https://github.com/apache/orc/pull/2240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "lahwaacz (via GitHub)" <gi...@apache.org>.
lahwaacz commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-3992805341
Apparently this is not relevant after https://github.com/apache/orc/pull/2416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-2906890047
cc @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-2908684673
I think lz4 and zlib have exported their packages to be used by config mode:
- https://github.com/lz4/lz4/blob/dev/build/cmake/lz4Config.cmake.in
- https://github.com/madler/zlib/blob/develop/CMakeLists.txt#L240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix CMake modules for finding external libraries [orc]
Posted by "lahwaacz (via GitHub)" <gi...@apache.org>.
lahwaacz commented on PR #2240:
URL: https://github.com/apache/orc/pull/2240#issuecomment-3992587487
Any progress with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org