[GitHub] [incubator-pinot] bradengroom commented on a change in pull request #5986: Improve code coverage for pinot-common

[GitBox <gi...@apache.org>]

bradengroom commented on a change in pull request #5986:
URL: https://github.com/apache/incubator-pinot/pull/5986#discussion_r483909440



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/function/AggregationFunctionType.java
##########
@@ -75,15 +75,6 @@ public String getName() {
     return _name;
   }
 
-  public boolean isOfType(AggregationFunctionType... aggregationFunctionTypes) {
-    for (AggregationFunctionType aggregationFunctionType : aggregationFunctionTypes) {
-      if (this == aggregationFunctionType) {
-        return true;
-      }
-    }
-    return false;
-  }

Review comment:
       This appears to be untested, but also unused. Is there a reason to keep this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org