You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/08 21:12:31 UTC

[kudu-CR] Fix false positive clang-tidy warning when using gtest 

Hello Dan Burkert,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7119

to review the following change.

Change subject: Fix false positive clang-tidy warning when using gtest
......................................................................

Fix false positive clang-tidy warning when using gtest

This applies a patch from https://reviews.llvm.org/D27048 to fix a false
positive that has surfaced since upgrading to LLVM 4.0.

I verified locally that this solved the spurious warnings on a test
file.

Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-fix-readability-redundant-declaration-false-positive.patch
2 files changed, 104 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/7119/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] Fix false positive clang-tidy warning when using gtest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.

Change subject: Fix false positive clang-tidy warning when using gtest
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix false positive clang-tidy warning when using gtest

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Fix false positive clang-tidy warning when using gtest
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Fix false positive clang-tidy warning when using gtest

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.

Change subject: Fix false positive clang-tidy warning when using gtest
......................................................................


Fix false positive clang-tidy warning when using gtest

This applies a patch from https://reviews.llvm.org/D27048 to fix a false
positive that has surfaced since upgrading to LLVM 4.0.

I verified locally that this solved the spurious warnings on a test
file.

Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
Reviewed-on: http://gerrit.cloudera.org:8080/7119
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-fix-readability-redundant-declaration-false-positive.patch
2 files changed, 104 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7119
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff972e198ba297a001b965f0012e1140112e553f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>