You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2018/01/18 05:29:05 UTC
[09/50] [abbrv] hbase git commit: HBASE-19810 Fix findbugs and
error-prone warnings in hbase-metrics (branch-2)
HBASE-19810 Fix findbugs and error-prone warnings in hbase-metrics (branch-2)
Signed-off-by: Michael Stack <st...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4676d4bf
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4676d4bf
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4676d4bf
Branch: refs/heads/HBASE-19397-branch-2
Commit: 4676d4bf4a86e94104b7432d24916baa31699706
Parents: 0561312
Author: Peter Somogyi <ps...@cloudera.com>
Authored: Wed Jan 17 10:05:03 2018 +0100
Committer: Michael Stack <st...@apache.org>
Committed: Wed Jan 17 11:26:07 2018 -0800
----------------------------------------------------------------------
.../org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java | 2 ++
.../apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java | 5 +++++
2 files changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/4676d4bf/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java
----------------------------------------------------------------------
diff --git a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java
index 6871f7e..7b79fba 100644
--- a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java
+++ b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/HistogramImpl.java
@@ -65,6 +65,7 @@ public class HistogramImpl implements Histogram {
histogram.add(value, 1);
}
+ @Override
public long getCount() {
return counter.getCount();
}
@@ -73,6 +74,7 @@ public class HistogramImpl implements Histogram {
return this.histogram.getMax();
}
+ @Override
public Snapshot snapshot() {
return histogram.snapshotAndReset();
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/4676d4bf/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java
----------------------------------------------------------------------
diff --git a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java
index d72c68f..3826e66 100644
--- a/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java
+++ b/hbase-metrics/src/main/java/org/apache/hadoop/hbase/metrics/impl/MetricRegistriesImpl.java
@@ -51,22 +51,27 @@ public class MetricRegistriesImpl extends MetricRegistries {
return registries.put(info, () -> factory.create(info));
}
+ @Override
public boolean remove(MetricRegistryInfo key) {
return registries.remove(key) == null;
}
+ @Override
public Optional<MetricRegistry> get(MetricRegistryInfo info) {
return Optional.ofNullable(registries.get(info));
}
+ @Override
public Collection<MetricRegistry> getMetricRegistries() {
return Collections.unmodifiableCollection(registries.values());
}
+ @Override
public void clear() {
registries.clear();
}
+ @Override
public Set<MetricRegistryInfo> getMetricRegistryInfos() {
return Collections.unmodifiableSet(registries.keySet());
}