You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dipti Desai (JIRA)" <ji...@codehaus.org> on 2013/01/31 15:13:13 UTC
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Dipti Desai created MCHECKSTYLE-186:
---------------------------------------
Summary: FileTabCharacter check not working
Key: MCHECKSTYLE-186
URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
Project: Maven 2.x Checkstyle Plugin
Issue Type: Bug
Reporter: Dipti Desai
Priority: Minor
The FileTabCharacter check doesnt seem to work. Below is my config:
<module name="Checker">
..
..
<!-- No TAB characters in the source code -->
<module name="FileTabCharacter">
<property name="eachLine" value="true" />
<property name="fileExtensions" value="java,xml" />
</module>
..
..
<module name="TreeWalker">
..
..
</module>
</module>
I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
Some additional info - my plugin config looks like this:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.9.1</version>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
<suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319908#comment-319908 ]
Dennis Lundberg commented on MCHECKSTYLE-186:
---------------------------------------------
Hi,
With the default configuration maven-checkstyle-plugin will only check java files. If you want it to check xml files you need to configure the plugin to do so.
Please use the "includes" configuration parameter.
> FileTabCharacter check not working
> ----------------------------------
>
> Key: MCHECKSTYLE-186
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Reporter: Dipti Desai
> Priority: Minor
>
> The FileTabCharacter check doesnt seem to work. Below is my config:
> {code:xml}
> <module name="Checker">
> ..
> ..
> <!-- No TAB characters in the source code -->
> <module name="FileTabCharacter">
> <property name="eachLine" value="true" />
> <property name="fileExtensions" value="java,xml" />
> </module>
> ..
> ..
> <module name="TreeWalker">
> ..
> ..
> </module>
> </module>
> {code}
> I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
> Some additional info - my plugin config looks like this:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <version>2.9.1</version>
> <executions>
> <execution>
> <phase>verify</phase>
> <goals>
> <goal>check</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
> <suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
> </configuration>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MCHECKSTYLE-186:
---------------------------------------
Description:
The FileTabCharacter check doesnt seem to work. Below is my config:
{code:xml}
<module name="Checker">
..
..
<!-- No TAB characters in the source code -->
<module name="FileTabCharacter">
<property name="eachLine" value="true" />
<property name="fileExtensions" value="java,xml" />
</module>
..
..
<module name="TreeWalker">
..
..
</module>
</module>
{code}
I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
Some additional info - my plugin config looks like this:
{code:xml}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.9.1</version>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
<suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
{code}
was:
The FileTabCharacter check doesnt seem to work. Below is my config:
<module name="Checker">
..
..
<!-- No TAB characters in the source code -->
<module name="FileTabCharacter">
<property name="eachLine" value="true" />
<property name="fileExtensions" value="java,xml" />
</module>
..
..
<module name="TreeWalker">
..
..
</module>
</module>
I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
Some additional info - my plugin config looks like this:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.9.1</version>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
<suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</plugin>
> FileTabCharacter check not working
> ----------------------------------
>
> Key: MCHECKSTYLE-186
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Reporter: Dipti Desai
> Priority: Minor
>
> The FileTabCharacter check doesnt seem to work. Below is my config:
> {code:xml}
> <module name="Checker">
> ..
> ..
> <!-- No TAB characters in the source code -->
> <module name="FileTabCharacter">
> <property name="eachLine" value="true" />
> <property name="fileExtensions" value="java,xml" />
> </module>
> ..
> ..
> <module name="TreeWalker">
> ..
> ..
> </module>
> </module>
> {code}
> I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
> Some additional info - my plugin config looks like this:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <version>2.9.1</version>
> <executions>
> <execution>
> <phase>verify</phase>
> <goals>
> <goal>check</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
> <suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
> </configuration>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Posted by "Dipti Desai (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320335#comment-320335 ]
Dipti Desai commented on MCHECKSTYLE-186:
-----------------------------------------
I did try this
{code}<includes>**/*.xml,**/*.java</includes>{code}
with and without the
{code}<property name="fileExtensions" value="java,xml,xsl,properties"/>{code}
but the xml files are not getting flagged. Any idea what might be going wrong?
> FileTabCharacter check not working
> ----------------------------------
>
> Key: MCHECKSTYLE-186
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Reporter: Dipti Desai
> Priority: Minor
>
> The FileTabCharacter check doesnt seem to work. Below is my config:
> {code:xml}
> <module name="Checker">
> ..
> ..
> <!-- No TAB characters in the source code -->
> <module name="FileTabCharacter">
> <property name="eachLine" value="true" />
> <property name="fileExtensions" value="java,xml" />
> </module>
> ..
> ..
> <module name="TreeWalker">
> ..
> ..
> </module>
> </module>
> {code}
> I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
> Some additional info - my plugin config looks like this:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <version>2.9.1</version>
> <executions>
> <execution>
> <phase>verify</phase>
> <goals>
> <goal>check</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
> <suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
> </configuration>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Posted by "Dipti Desai (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=319889#comment-319889 ]
Dipti Desai commented on MCHECKSTYLE-186:
-----------------------------------------
Thanks for your reply. I went through the linked issue and the revisions mentioned there. I may be missing something out here but I didn't really find anything specific that could validate my xml files. Could you please elaborate a little on what could fix this issue?
> FileTabCharacter check not working
> ----------------------------------
>
> Key: MCHECKSTYLE-186
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Reporter: Dipti Desai
> Priority: Minor
>
> The FileTabCharacter check doesnt seem to work. Below is my config:
> {code:xml}
> <module name="Checker">
> ..
> ..
> <!-- No TAB characters in the source code -->
> <module name="FileTabCharacter">
> <property name="eachLine" value="true" />
> <property name="fileExtensions" value="java,xml" />
> </module>
> ..
> ..
> <module name="TreeWalker">
> ..
> ..
> </module>
> </module>
> {code}
> I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
> Some additional info - my plugin config looks like this:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <version>2.9.1</version>
> <executions>
> <execution>
> <phase>verify</phase>
> <goals>
> <goal>check</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
> <suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
> </configuration>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MCHECKSTYLE-186) FileTabCharacter check not working
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MCHECKSTYLE-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320340#comment-320340 ]
Dennis Lundberg commented on MCHECKSTYLE-186:
---------------------------------------------
How have you configured <sourceDirectory>? I'm guessing you haven't.
Where are your xml-files?
Are they in the ${project.build.sourceDirectory} directory? I'm guessing no.
If not, then you need to configure the <sourceDirectory> as well.
> FileTabCharacter check not working
> ----------------------------------
>
> Key: MCHECKSTYLE-186
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-186
> Project: Maven 2.x Checkstyle Plugin
> Issue Type: Bug
> Reporter: Dipti Desai
> Priority: Minor
>
> The FileTabCharacter check doesnt seem to work. Below is my config:
> {code:xml}
> <module name="Checker">
> ..
> ..
> <!-- No TAB characters in the source code -->
> <module name="FileTabCharacter">
> <property name="eachLine" value="true" />
> <property name="fileExtensions" value="java,xml" />
> </module>
> ..
> ..
> <module name="TreeWalker">
> ..
> ..
> </module>
> </module>
> {code}
> I have my xml files - pom.xml and checkstyle config xml containing tabs but none of them are flagged as violations.
> Some additional info - my plugin config looks like this:
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-checkstyle-plugin</artifactId>
> <version>2.9.1</version>
> <executions>
> <execution>
> <phase>verify</phase>
> <goals>
> <goal>check</goal>
> </goals>
> </execution>
> </executions>
> <configuration>
> <configLocation>checkstyle/kepler-checkstyle-config.xml</configLocation>
> <suppressionsLocation>${project.parent.basedir}${file.separator}checkstyle/kepler-checkstyle-suppressions.xml</suppressionsLocation>
> </configuration>
> </plugin>
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira