You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/04/12 14:44:18 UTC

[GitHub] [systemds] sebwrede commented on pull request #1184: [SYSTEMDS-2863] Federated ctable instruction

sebwrede commented on pull request #1184:
URL: https://github.com/apache/systemds/pull/1184#issuecomment-817872073


   As I said a couple of weeks ago, this PR looks really good. I think we need to do two things before merging: 
   
   1. Add more test cases. I looked through the processInstruction code, but I find it difficult to convince myself that the code works if the test cases do not cover more process cases. 
   2. Resolve the conflicting files.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org