You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rm...@apache.org on 2020/09/20 21:19:57 UTC

[logging-log4cxx] branch master updated: Don't remove generated files on clean

This is an automated email from the ASF dual-hosted git repository.

rmiddleton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4cxx.git


The following commit(s) were added to refs/heads/master by this push:
     new aa1820c  Don't remove generated files on clean
     new c6fe4f8  Merge pull request #41 from rm5248/cmake-clean-fix
aa1820c is described below

commit aa1820c1b4b1376e84b3bd72249370718ff0ae8d
Author: Robert Middleton <ro...@rm5248.com>
AuthorDate: Sun Sep 20 10:38:32 2020 -0400

    Don't remove generated files on clean
    
    When generated files are removed on clean, the build will
    fail because log4cxx.h is not found, and cmake must be run
    again.  The files still get regenrated anyway.
---
 src/main/include/CMakeLists.txt | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/main/include/CMakeLists.txt b/src/main/include/CMakeLists.txt
index a8b0f40..97f286d 100644
--- a/src/main/include/CMakeLists.txt
+++ b/src/main/include/CMakeLists.txt
@@ -10,9 +10,6 @@ add_custom_target(configure_log4cxx
   DEPENDS
     ${CMAKE_CURRENT_SOURCE_DIR}/log4cxx/log4cxx.hw
     ${CMAKE_CURRENT_SOURCE_DIR}/log4cxx/private/log4cxx_private.hw
-  BYPRODUCTS
-    ${CMAKE_CURRENT_BINARY_DIR}/log4cxx/log4cxx.h
-    ${CMAKE_CURRENT_BINARY_DIR}/log4cxx/private/log4cxx_private.h
 )
 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/log4cxx/version_info.h.in
                ${CMAKE_CURRENT_BINARY_DIR}/log4cxx/version_info.h
@@ -112,8 +109,5 @@ add_custom_target(configure_log4cxx
   DEPENDS
     ${CMAKE_CURRENT_SOURCE_DIR}/log4cxx/log4cxx.h.in
     ${CMAKE_CURRENT_SOURCE_DIR}/log4cxx/private/log4cxx_private.h.in
-  BYPRODUCTS
-    ${CMAKE_CURRENT_BINARY_DIR}/log4cxx/log4cxx.h
-    ${CMAKE_CURRENT_BINARY_DIR}/log4cxx/private/log4cxx_private.h
 )
 endif()