You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/19 12:16:58 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request, #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
healchow opened a new pull request, #4271:
URL: https://github.com/apache/incubator-inlong/pull/4271
### Title Name: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
Fixes #4270
### Motivation
Inlong group supports extensions of different types of MQ.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [X] This change is already covered by existing tests, such as:
### Documentation
- Does this pull request introduces a new feature? (yes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4271:
URL: https://github.com/apache/incubator-inlong/pull/4271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4271:
URL: https://github.com/apache/incubator-inlong/pull/4271#discussion_r877688271
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongStreamEntityMapper.xml:
##########
@@ -258,18 +258,18 @@
stream.data_separator, stream.data_escape_char, stream.sync_send, stream.daily_records,
stream.daily_storage, stream.peak_records, stream.max_length, stream.storage_period,
stream.status, stream.creator, stream.modifier, stream.create_time, stream.modify_time
- from inlong_stream stream, inlong_group group, workflow_approver approver
+ from inlong_stream stream, inlong_group grp, workflow_approver approver
Review Comment:
It is the keyword in the h2 database:
<img width="1457" alt="image" src="https://user-images.githubusercontent.com/31994335/169439232-2d2b5418-ead4-453f-9dab-7b3739da584e.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a diff in pull request #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
Posted by GitBox <gi...@apache.org>.
kipshi commented on code in PR #4271:
URL: https://github.com/apache/incubator-inlong/pull/4271#discussion_r877684236
##########
inlong-manager/manager-dao/src/main/resources/mappers/InlongStreamEntityMapper.xml:
##########
@@ -258,18 +258,18 @@
stream.data_separator, stream.data_escape_char, stream.sync_send, stream.daily_records,
stream.daily_storage, stream.peak_records, stream.max_length, stream.storage_period,
stream.status, stream.creator, stream.modifier, stream.create_time, stream.modify_time
- from inlong_stream stream, inlong_group group, workflow_approver approver
+ from inlong_stream stream, inlong_group grp, workflow_approver approver
Review Comment:
not necessary change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow closed pull request #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
Posted by GitBox <gi...@apache.org>.
healchow closed pull request #4271: [INLONG-4270][Manager] Inlong group supports extensions of different types of MQ
URL: https://github.com/apache/incubator-inlong/pull/4271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org