You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/10/01 17:13:27 UTC

[GitHub] [couchdb] dottorblaster commented on a change in pull request #3187: 3x backport - Port various elixir tests

dottorblaster commented on a change in pull request #3187:
URL: https://github.com/apache/couchdb/pull/3187#discussion_r498397563



##########
File path: src/chttpd/src/chttpd_rewrite.erl
##########
@@ -71,8 +71,9 @@ do_rewrite(#httpd{mochi_req=MochiReq}=Req, {Props}=Rewrite) when is_list(Props)
                 undefined -> erlang:get(mochiweb_request_body);
                 B -> B
             end,
+            NewMochiReq:cleanup(),
             case Body of
-                undefined -> NewMochiReq:cleanup();
+                undefined -> [];
                 _ -> erlang:put(mochiweb_request_body, Body)

Review comment:
       Are you sure this has to be backported? It's not elixir




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org