You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/12 14:29:07 UTC

[GitHub] [arrow] eitsupi commented on a diff in pull request #14092: ARROW-17674: [R] Implement dplyr::across() inside arrange()

eitsupi commented on code in PR #14092:
URL: https://github.com/apache/arrow/pull/14092#discussion_r968492844


##########
r/R/dplyr-arrange.R:
##########
@@ -20,7 +20,10 @@
 
 arrange.arrow_dplyr_query <- function(.data, ..., .by_group = FALSE) {
   call <- match.call()
-  exprs <- quos(...)
+
+  expression_list <- expand_across(.data, quos(...))
+  exprs <- ensure_named_exprs(expression_list)

Review Comment:
   Thank you for taking a look. I have removed the unnecessary lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org