You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/08/25 08:02:49 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

GitHub user bhaisaab opened a pull request:

    https://github.com/apache/cloudstack/pull/739

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template…

    … listing
    
    Uses listViewDataProvider to implement pagination on listTemplates API
    requests in the UI, when a template's zone tab is viewed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-8766

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #739
    
----
commit 95c76efc3944aab9a620559a026fe37e53d8f53d
Author: Rohit Yadav <ro...@shapeblue.com>
Date:   2015-08-25T05:59:21Z

    CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal template listing
    
    Uses listViewDataProvider to implement pagination on listTemplates API
    requests in the UI, when a template's zone tab is viewed.
    
    Signed-off-by: Rohit Yadav <ro...@shapeblue.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/739#issuecomment-134872958
  
    I've add a similar fix for listing iso/zone page and also added code that would de-dupe any isos and templates in the main list view.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:

    https://github.com/apache/cloudstack/pull/739#issuecomment-134523852
  
    thanks @karuturi the screenshots are from a 4.5 env, I've tested this on 4.5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:

    https://github.com/apache/cloudstack/pull/739#issuecomment-134522790
  
    :+1:  as per #740 (I havent tested it on 4.5)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/739#issuecomment-135201859
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8766: Fix infinite scrolling p...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/739


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---