Re: [PR] make dh group 31 default, support 22-24+31 [cloudstack]

["sureshanaparti (via GitHub)" <gi...@apache.org>]

sureshanaparti commented on PR #12764:
URL: https://github.com/apache/cloudstack/pull/12764#issuecomment-4325254366

   > > LGTM, by default the group is now 31
   > 
   > @borisstoyanov Strongswan in the VR does say that it supports the new dh groups, but please see if some end-to-end testing with few of these is required.
   > 
   > ```
   > root@r-13-VM:~# ipsec listalgs
   > List of registered IKE algorithms:
   > 
   >   encryption: AES_CBC[aes] AES_ECB[aes] RC2_CBC[rc2] 3DES_CBC[gcrypt] AES_CTR[gcrypt] AES_CFB[gcrypt]
   >               BLOWFISH_CBC[gcrypt] CAMELLIA_CTR[gcrypt] CAMELLIA_CBC[gcrypt] CAST_CBC[gcrypt] DES_CBC[gcrypt]
   >               DES_ECB[gcrypt] SERPENT_CBC[gcrypt] TWOFISH_CBC[gcrypt]
   > ....
   >   dh-group:   MODP_3072[gcrypt] MODP_4096[gcrypt] MODP_6144[gcrypt] MODP_8192[gcrypt] MODP_2048[gcrypt]
   >               MODP_2048_224[gcrypt] MODP_2048_256[gcrypt] MODP_1536[gcrypt] MODP_1024[gcrypt] MODP_1024_160[gcrypt]
   >               MODP_768[gcrypt] MODP_CUSTOM[gcrypt] CURVE_25519[curve25519]
   >   random-gen: RNG_WEAK[gcrypt] RNG_STRONG[random] RNG_TRUE[random]
   >   nonce-gen:  [nonce]
   > ```
   
   @borisstoyanov can you check if the tests advised by Abhisar are needed here or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org