You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Michael McKibben <mi...@hihat.net> on 2002/02/05 03:23:10 UTC

Questions on the new Container classes

I've been browsing through the new container classes in excalibur
scratchpad and the idea looks promising! I think I may have found a few
issues though (at least in the lastest public CVS). It looks like the
class org.apache.avalon.excalibur.system.handler.DefaultComponentHandler
is defined in a file named FactoryComponentHandler. Either the file or
class needs to be renamed. Another problem I think is in the
ContainerManager class. Inside getComponentManager() it initializes a
SourceResovlerImpl and then a ResourceSourceFactory. I think the ordering
of this initialization neeeds to be swapped or else the SourceResolverImpl
will throw a ComponentException during compose as it requires a
SourceFactorySelector in the ComponentManager.

Regards,

--mike


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [PATCH] Was Re: Questions on the new Container classes

Posted by Berin Loritsch <bl...@apache.org>.
Michael McKibben wrote:

> No problem. I thought I'd give you a head start and submit a patch for
> what I found. Thanks, 
> 


Thank you very much for your assistance.  It will help me in the future
if you use the "-u" option for diff files:

cvs -z3 diff -N -ub

This allows the CVS to check against new files and use the "universal"
format that is friendly to both humans and machines, and ignore whitespace
changes.

It is a little more intuitive when you see "-" and "+" instead of the
exclamation point.

Hopefully we can knock the rest of this out ASAP!


-- 

"They that give up essential liberty to obtain a little temporary safety
  deserve neither liberty nor safety."
                 - Benjamin Franklin


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


[PATCH] Was Re: Questions on the new Container classes

Posted by Michael McKibben <mi...@hihat.net>.
No problem. I thought I'd give you a head start and submit a patch for
what I found. Thanks, 

Regards,

On Mon, 4 Feb 2002, Berin Loritsch wrote:

> Michael McKibben wrote:
> 
> > I've been browsing through the new container classes in excalibur
> > scratchpad and the idea looks promising! I think I may have found a few
> > issues though (at least in the lastest public CVS). It looks like the
> > class org.apache.avalon.excalibur.system.handler.DefaultComponentHandler
> > is defined in a file named FactoryComponentHandler. Either the file or
> > class needs to be renamed. Another problem I think is in the
> > ContainerManager class. Inside getComponentManager() it initializes a
> > SourceResovlerImpl and then a ResourceSourceFactory. I think the ordering
> > of this initialization neeeds to be swapped or else the SourceResolverImpl
> > will throw a ComponentException during compose as it requires a
> > SourceFactorySelector in the ComponentManager.
> 
> 
> Ok.  I am actually at a place where I can shake out some bugs.  I will 
> be working on it tomorrow (along with my PrintNode client to my 
> PrintServer).
> 
> 
> ----------------------------------------------------
> Sign Up for NetZero Platinum Today
> Only $9.95 per month!
> http://my.netzero.net/s/signup?r=platinum&refcd=PT97
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 

Re: Questions on the new Container classes

Posted by Berin Loritsch <bl...@apache.org>.
Michael McKibben wrote:

> I've been browsing through the new container classes in excalibur
> scratchpad and the idea looks promising! I think I may have found a few
> issues though (at least in the lastest public CVS). It looks like the
> class org.apache.avalon.excalibur.system.handler.DefaultComponentHandler
> is defined in a file named FactoryComponentHandler. Either the file or
> class needs to be renamed. Another problem I think is in the
> ContainerManager class. Inside getComponentManager() it initializes a
> SourceResovlerImpl and then a ResourceSourceFactory. I think the ordering
> of this initialization neeeds to be swapped or else the SourceResolverImpl
> will throw a ComponentException during compose as it requires a
> SourceFactorySelector in the ComponentManager.


Ok.  I am actually at a place where I can shake out some bugs.  I will 
be working on it tomorrow (along with my PrintNode client to my 
PrintServer).


----------------------------------------------------
Sign Up for NetZero Platinum Today
Only $9.95 per month!
http://my.netzero.net/s/signup?r=platinum&refcd=PT97

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>