You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/16 14:24:43 UTC

Review Request 26807: Slider View. Add App Wizard. Back from 3rd to 2nd step issue

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26807/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.


Bugs: ambari-7813
    https://issues.apache.org/jira/browse/ambari-7813


Repository: ambari


Description
-------

Values for components count, memory, labels doesn't restored from newApp.
Default values used.


Diffs
-----

  contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 7adbf08 
  contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js a26d22c 

Diff: https://reviews.apache.org/r/26807/diff/


Testing
-------

Tests completed in 7362 milliseconds.
107 assertions of 107 passed, 0 failed.


Thanks,

Oleg Nechiporenko


Re: Review Request 26807: Slider View. Add App Wizard. Back from 3rd to 2nd step issue

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26807/#review56918
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 16, 2014, 12:24 п.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26807/
> -----------------------------------------------------------
> 
> (Updated Окт. 16, 2014, 12:24 п.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: ambari-7813
>     https://issues.apache.org/jira/browse/ambari-7813
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Values for components count, memory, labels doesn't restored from newApp.
> Default values used.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 7adbf08 
>   contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js a26d22c 
> 
> Diff: https://reviews.apache.org/r/26807/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7362 milliseconds.
> 107 assertions of 107 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Re: Review Request 26807: Slider View. Add App Wizard. Back from 3rd to 2nd step issue

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26807/#review56917
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 16, 2014, 12:24 після полудня, Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26807/
> -----------------------------------------------------------
> 
> (Updated Жов. 16, 2014, 12:24 після полудня)
> 
> 
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
> 
> 
> Bugs: ambari-7813
>     https://issues.apache.org/jira/browse/ambari-7813
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Values for components count, memory, labels doesn't restored from newApp.
> Default values used.
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step2_controller.js 7adbf08 
>   contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js a26d22c 
> 
> Diff: https://reviews.apache.org/r/26807/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7362 milliseconds.
> 107 assertions of 107 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>