You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/09 17:19:04 UTC

[jira] [Commented] (BOOKKEEPER-1050) Cache journalFormatVersionToWrite when starting Journal

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003098#comment-16003098 ] 

ASF GitHub Bot commented on BOOKKEEPER-1050:
--------------------------------------------

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/140

    BOOKKEEPER-1050: Cache journalFormatVersionToWrite when starting Journal

    Reading the journal version format from `ServiceConfiguration` each time is inefficient.
    `ServiceConfiguration` is based on Java properties which is based on a String to object hashtable. Each read implies acquiring a mutex and converting from object to int.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper cache-journal-conf

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 68d5e8322e466ec1aed61355e1415b09da4b7f1f
Author: Matteo Merli <mm...@apache.org>
Date:   2015-10-08T08:21:24Z

    BOOKKEEPER-1050: Cache journalFormatVersionToWrite when starting Journal

----


> Cache journalFormatVersionToWrite when starting Journal
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-1050
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-1050
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Matteo Merli
>            Assignee: Matteo Merli
>            Priority: Minor
>             Fix For: 4.5.0
>
>
> Reading the journal version format from {{ServiceConfiguration}} each time is inefficient. 
> {{ServiceConfiguration}} is based on Java properties which is based on a String to object hashtable. Each read implies acquiring a mutex and converting from object to int.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)