You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/09 14:45:01 UTC
[jira] [Commented] (ARTEMIS-1796) Flush during handshake of AMQP
can cause issues with SASL clients
[ https://issues.apache.org/jira/browse/ARTEMIS-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430622#comment-16430622 ]
ASF GitHub Bot commented on ARTEMIS-1796:
-----------------------------------------
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2002
ARTEMIS-1796 AMQP flush during handshake can break SASL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1796
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2002
----
commit c74a09fbeda8f7d97992f7be86368fe1f7293f9b
Author: Clebert Suconic <cl...@...>
Date: 2018-04-09T14:43:29Z
ARTEMIS-1796 AMQP flush during handshake can break SASL
----
> Flush during handshake of AMQP can cause issues with SASL clients
> -----------------------------------------------------------------
>
> Key: ARTEMIS-1796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1796
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.5.0
> Environment: I found this by setting up a debug point on the handshake. But as I saw it the flush could still happen shortly after causing intermittent issues with SASL clients.
>
> The flush should be deferred until the initial handshake is finished. This is as simple as only doing the flush if the first packet was received, and that would be enough for this.
>
> The solution I'm implementing is to differentiate flushes from scheduled flushes, and doing a regular flush if the first packet was received.
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.5.1
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)