You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/28 15:30:17 UTC

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #23126: Add IF NOT EXISTS to CREATE READWRITE_SPLITTING RULE.

RaigorJiang commented on code in PR #23126:
URL: https://github.com/apache/shardingsphere/pull/23126#discussion_r1058425950


##########
features/readwrite-splitting/distsql/handler/src/main/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/checker/ReadwriteSplittingRuleStatementChecker.java:
##########
@@ -55,18 +55,21 @@ public final class ReadwriteSplittingRuleStatementChecker {
      * @param database database
      * @param segments segments
      * @param currentRuleConfig current rule config
+     * @param duplicatedRuleNames duplicate rule names

Review Comment:
   `duplicate` should be `duplicated`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org