You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 18:44:12 UTC
[GitHub] [airflow] pateash opened a new pull request #21946: [WIP]: Allowing user to pin connection and variable at top
pateash opened a new pull request #21946:
URL: https://github.com/apache/airflow/pull/21946
closes: #21720
---
### Description
This PR allows user to pin important Connection and Variables on Top.
Implementation is really straight forward, we will add a new column into the tables having information about pinned connection/variable and while rendering we sort according to pinned column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058242698
@ashb I think that the user's ask was to be able to pin some useful connections at the top which help their team manage operations.
Agree with @bbovenzi that we can use local storage, but that will not work everywhere, also different users will have to do it for themselves.
Also, I think the priority(pinning) should be up to the user to decide and it should be persistent.
I think it would be frustrating to loose that information once you switch devices or even browsers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058009840
Storing this in the database (at least against the Connection table) explicitly won't fix the original ask by the user -- as they have a long list and different users would want different connections at the top..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057264176
Pinning at Top:


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057263684
Pinned Connections and views


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058291360
@SangwanP thanks for the clarification.
@bbovenzi @kaxil @ashb
if the requirement is to have user-specific temporary pinned connections/views, I agree that local storage is a better solution.
If it isn't a useful feature to have persisted pinning, I will close this PR,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058002486
>
I think we have to have the information about the columns to be pinned stored in metadatabase.
Otherwise, it will be lost upon browser refresh and All the users will have to pin for them everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058007169
Can it not be stored in a browser cookie like https://github.com/apache/airflow/pull/11661/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057263684
Pinned Connections and views
----


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi edited a comment on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
bbovenzi edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058204560
Without a db connection. We could use localstorage, but that would then only apply to that specific browser/computer. We already do this for auto-refresh, and collapsing/expanding groups in tree/graph views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] SangwanP commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
SangwanP commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058273610
Hi @pateash, I created the issue: #21720. Technical implementation aside, I was expecting, from a user experience perspective, the pin would be a button on the {variable, connection} list page, similar to edit, delete, or show.
Additionally, having to pin through the edit page, might have some user permissions implications & connection password management issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058002486
I think we have to have the information about the columns to be pinned stored in metadatabase.
Otherwise, it will be lost upon browser refresh and All the users will have to pin them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058002486
I think we have to store the information about the columns to be pinned stored in metadatabase.
Otherwise, it will be lost upon browser refresh and All the users will have to pin them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057263684
Pinned Connections and views
----


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057264176
Pinning at Top:
------


--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pateash edited a comment on pull request #21946: [WIP]: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
pateash edited a comment on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1057263684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #21946: Allowing user to pin connection and variable at top
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #21946:
URL: https://github.com/apache/airflow/pull/21946#issuecomment-1058204560
Without a db connection. We could use localstorage, but that would then only apply to that specific browser/computer. We already do this auto-refresh, and collapsing/expanding groups in tree/graph views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org