You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/21 02:53:51 UTC
[GitHub] [flink] liupc opened a new pull request #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
liupc opened a new pull request #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910
## What is the purpose of the change
Currently, Flink sqlClient still use hardcoded `parentFirst` classloader to load user specified jars and libraries, this is easily causing classes conflicts. In [FLINK-13749](https://issues.apache.org/jira/browse/FLINK-13749) , we already make the classloader consistent in both client and remote components.
So this PR will try to do the same for sqlClient, and make the classloaders consistent.
## Brief change log
- *Make the classloader of sqlClient respecting the classloading policy and thus make it consistent with other flink components*
## Verifying this change
TODO
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:MANUAL TriggerID:581278981
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:MANUAL TriggerID:581278981
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145316208) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145316208) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun merged pull request #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:MANUAL TriggerID:581278981
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:MANUAL TriggerID:581278981
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145316208) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liupc commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
liupc commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-581278981
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liupc commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
liupc commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576540983
@TisonKun Thanks for reply, it's good to use `ClientUtils.buildUserCodeClassLoader` to deduplicate codes. I've updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-586718737
@liupc Thanks for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] liupc commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
liupc commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-586181073
@TisonKun gentle ping~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:MANUAL TriggerID:581278981
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145316208) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576496749
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa (Tue Jan 21 02:56:28 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15702).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10910: [FLINK-15702][SQL]Make
sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145316208 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
Hash:cd98feb63052849d0271733b3384a95d6c6bcde3 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526 TriggerType:PUSH TriggerID:cd98feb63052849d0271733b3384a95d6c6bcde3
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
* cd98feb63052849d0271733b3384a95d6c6bcde3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145316208) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4526)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10910:
[FLINK-15702][SQL]Make sqlClient classloader aligned with other components
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10910: [FLINK-15702][SQL]Make sqlClient classloader aligned with other components
URL: https://github.com/apache/flink/pull/10910#issuecomment-576505209
<!--
Meta data
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/145303899 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
Hash:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520 TriggerType:PUSH TriggerID:8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa
-->
## CI report:
* 8333b02c2d8e703f9b3ef25dae0e1f6d2c43e2aa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/145303899) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4520)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services