[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6481: Add SELECT * EXCLUDE, SELECT * EXCEPT support

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6481:
URL: https://github.com/apache/arrow-datafusion/pull/6481#discussion_r1210385662


##########
datafusion/core/tests/sqllogictests/test_files/select.slt:
##########
@@ -759,6 +759,64 @@ SELECT a FROM annotated_data_finite2
 0
 0
 
+# Below query should emit all the columns except a and b

Review Comment:
   I am probably missing something, but these queries all appear to produce three output columns (a, b, and c), right? I am perhaps fundamentally misunderstanding what `EXCLUDE` is supposed to do or misunderstanding the comments



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org