You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@subversion.apache.org by "Nathan Hartman (Jira)" <ji...@apache.org> on 2022/08/15 17:27:00 UTC

[jira] [Created] (SVN-4906) svn patch adds newline to last line of file with svn:eol-style

Nathan Hartman created SVN-4906:
-----------------------------------

             Summary: svn patch adds newline to last line of file with svn:eol-style
                 Key: SVN-4906
                 URL: https://issues.apache.org/jira/browse/SVN-4906
             Project: Subversion
          Issue Type: Bug
          Components: cmdline client
    Affects Versions: 1.14.2
            Reporter: Nathan Hartman
         Attachments: reproduction-script.txt

When a versioned file has the svn:eol-style property, the last line of the file does not end with a newline, and the user applies a patch with 'svn patch' (where the patch does not contain changes to the last line or any lines near it), 'svn patch' adds a newline to the last line of the file.

I've confirmed that the same issue is reproduced for all possible values of svn:eol-style (native, LF, CRLF, CR).

This issue was found by Vincent Lefevre, who provided the following reproduction script (see attachment).

References:

Mail thread: dev thread "[BUG] svn patch with svn:eol-style set to native" started 14 August 2022: [https://lists.apache.org/thread/6pm44zc0kq4d63nfh8h5bw7llfctp6cy]

Originally discovered in dev thread "[PATCH] URL update to https" -- see the part starting with "Are you sure" in 14 August 2022 message:[ https://lists.apache.org/thread/w0fld2p0qzg5oo6tqgw1tcvtolndvg9t|https://lists.apache.org/thread/w0fld2p0qzg5oo6tqgw1tcvtolndvg9t]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)