You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/05/02 17:36:04 UTC

Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.


This addresses bug CLOUDSTACK-2303.


Diffs
-----

  server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 

Diff: https://reviews.apache.org/r/10904/diff/


Testing
-------

Testing manually ok.


Thanks,

Wei Zhou


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20084
-----------------------------------------------------------

Ship it!


Ship It!

- Chip Childers


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20083
-----------------------------------------------------------


Commit 4640fbf36dba3074bc9f715dae50cba62a49d571 in branch refs/heads/4.1 from Chip Childers <ch...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4640fbf ]

CLOUDSTACK-2303: fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from
http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
so the upgrade processing from 2.2.14 to 4.1.0 will abort at
updateSystemVms in Upgrade2214to30.java.

Signed-off-by: Chip Childers <ch...@apache.org>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by Wei Zhou <w....@leaseweb.com>.

> On May 2, 2013, 3:38 p.m., Chip Childers wrote:
> > Before we apply this, I'm trying to get clarification as to the correct version # for the SSVM in 4.1.  AFAIK, it's actually supposed to be 3.0.x still.  The latest release notes (not the ones in the URL you mention) were edited to correctly match the 4.0.x series, since we are not updating the SSVM images as part of 4.1.0.

I noticed the version of systemvm for vmware in Release Notes has been changed to 3.0.5.
(https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=06371ba;hp=2dc278e98660f0cecb0e161c9c5540b5b2a39a9e)

I think, the source code also need to be modified to deal with the version change from 3.0.0 to 3.0.5, or other later versions.


- Wei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20080
-----------------------------------------------------------


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20080
-----------------------------------------------------------


Before we apply this, I'm trying to get clarification as to the correct version # for the SSVM in 4.1.  AFAIK, it's actually supposed to be 3.0.x still.  The latest release notes (not the ones in the URL you mention) were edited to correctly match the 4.0.x series, since we are not updating the SSVM images as part of 4.1.0.

- Chip Childers


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20087
-----------------------------------------------------------


Commit f8504c096054d638fb5ed1e21e55243653c4649a in branch refs/heads/ui-cisco-asa1000v-support from Chip Childers <ch...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f8504c0 ]

CLOUDSTACK-2303: fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from
http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
so the upgrade processing from 2.2.14 to 4.1.0 will abort at
updateSystemVms in Upgrade2214to30.java.

Signed-off-by: Chip Childers <ch...@apache.org>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20140
-----------------------------------------------------------


Commit a3a5c13427d6871f87da291425314b18ef64fa2a in branch refs/heads/internallb from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a3a5c13 ]

CLOUDSTACK-2303: upgrade failed from 2.2.14 to 4.1.0 - part2

Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20118
-----------------------------------------------------------


Commit 4dbeefcc0d9d637d039f61f587f9581bdc88595b in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4dbeefc ]

CLOUDSTACK-2303: upgrade failed from 2.2.14 to 4.1.0 - part2

Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20121
-----------------------------------------------------------


Commit a3a5c13427d6871f87da291425314b18ef64fa2a in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a3a5c13 ]

CLOUDSTACK-2303: upgrade failed from 2.2.14 to 4.1.0 - part2

Signed-off-by: Chip Childers <ch...@gmail.com>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>


Re: Review Request: (CLOUDSTACK-2303) fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10904/#review20086
-----------------------------------------------------------


Commit f8504c096054d638fb5ed1e21e55243653c4649a in branch refs/heads/master from Chip Childers <ch...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f8504c0 ]

CLOUDSTACK-2303: fix upgrade failed from 2.2.14 to 4.1.0 for systemvm changes

The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from
http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
so the upgrade processing from 2.2.14 to 4.1.0 will abort at
updateSystemVms in Upgrade2214to30.java.

Signed-off-by: Chip Childers <ch...@apache.org>


- ASF Subversion and Git Services


On May 2, 2013, 3:36 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10904/
> -----------------------------------------------------------
> 
> (Updated May 2, 2013, 3:36 p.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> The version of systemvm of 3.* and 4.0.* is systemvm-kvm-3.0.0.(from http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/pdf/Release_Notes/Apache_CloudStack-4.0.2-Release_Notes-en-US.pdf)
> However, on cloudstack 4.1.0, the systemvm version is 4.1.0. (from http://dissociatedpress.net/uploads/Apache_CloudStack-4.1.0-Release_Notes-en-US.pdf)
> so the upgrade processing from 2.2.14 to 4.1.0 will abort at updateSystemVms in Upgrade2214to30.java.
> 
> 
> This addresses bug CLOUDSTACK-2303.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 8c4dbec 
> 
> Diff: https://reviews.apache.org/r/10904/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>