You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bluemarlin.apache.org by Reza Adibnia <re...@futurewei.com> on 2021/03/09 01:29:40 UTC

commits to incubator-bluemarlin

Hi JB,

I went through some documents to learn about Apache Way as a committer.

https://infra.apache.org/new-committers-guide.html
https://infra.apache.org/release-signing.html
https://infra.apache.org/release-publishing.html

To my understanding I can create different branches and commit code to the main branch of incubator-bluemarlin easily. Only having a release requires a process to go through.

Please let me know if I am correct. I have couple of updates to commit.

Also, if there is any other document to read as a committer please let me know.

Best,

Reza.

Re: commits to incubator-bluemarlin

Posted by Jean-Baptiste Onofre <jb...@nanthrax.net>.
Hi Xun,

No, you can push directly on main/master branch, no problem.

However, to allow committers to do review, etc, I think it’s better to create PRs.

Minor changes can be pushed directly on master/main branch.

Regards
JB

> Le 9 mars 2021 à 07:00, Xun Hu <xu...@futurewei.com> a écrit :
> 
> Hi, JB,
> 
> Thanks for the clarification. One more question here, does it mean that we should not change code on master branch??
> 
> Regards,
> -xun
> 
> 
> -----Original Message-----
> From: Jean-Baptiste Onofre <jb@nanthrax.net <ma...@nanthrax.net>> 
> Sent: Monday, March 8, 2021 9:15 PM
> To: dev@bluemarlin.apache.org <ma...@bluemarlin.apache.org>
> Subject: Re: commits to incubator-bluemarlin
> 
> Hi Reza,
> 
> To create PR, you can create the branches on a BlueMarlin fork on your own GitHub repo (no need to create branches for PR on BlueMarlin repo).
> 
> For release, I will do the first one with you, but it's not fully ready yet (in terms of artifacts, etc). I have to do some updates still.
> 
> Regards
> JB
> 
>> Le 9 mars 2021 à 02:29, Reza Adibnia <re...@futurewei.com> a écrit :
>> 
>> Hi JB,
>> 
>> I went through some documents to learn about Apache Way as a committer.
>> 
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Fnew-committers-guide.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=wHzc5oXKpuWga0WmJrRNp1Le%2F%2FywKmThVRLni642SME%3D&amp;reserved=0 <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Fnew-committers-guide.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=wHzc5oXKpuWga0WmJrRNp1Le%2F%2FywKmThVRLni642SME%3D&amp;reserved=0>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-signing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=zEXu6uCV04PYrAK3u8mABuQwyiFAjCAM7Tk3JyK60OY%3D&amp;reserved=0 <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-signing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=zEXu6uCV04PYrAK3u8mABuQwyiFAjCAM7Tk3JyK60OY%3D&amp;reserved=0>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-publishing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145806791%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=yTHjwcBVUx7%2Fc8obH%2BMIFEaCrOBU%2BLufSYkJ4hN4Dxk%3D&amp;reserved=0 <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-publishing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145806791%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=yTHjwcBVUx7%2Fc8obH%2BMIFEaCrOBU%2BLufSYkJ4hN4Dxk%3D&amp;reserved=0>
>> 
>> To my understanding I can create different branches and commit code to the main branch of incubator-bluemarlin easily. Only having a release requires a process to go through.
>> 
>> Please let me know if I am correct. I have couple of updates to commit.
>> 
>> Also, if there is any other document to read as a committer please let me know.
>> 
>> Best,
>> 
>> Reza.


RE: commits to incubator-bluemarlin

Posted by Xun Hu <xu...@futurewei.com>.
Hi, JB,

Thanks for the clarification. One more question here, does it mean that we should not change code on master branch??

Regards,
-xun


-----Original Message-----
From: Jean-Baptiste Onofre <jb...@nanthrax.net> 
Sent: Monday, March 8, 2021 9:15 PM
To: dev@bluemarlin.apache.org
Subject: Re: commits to incubator-bluemarlin

Hi Reza,

To create PR, you can create the branches on a BlueMarlin fork on your own GitHub repo (no need to create branches for PR on BlueMarlin repo).

For release, I will do the first one with you, but it's not fully ready yet (in terms of artifacts, etc). I have to do some updates still.

Regards
JB

> Le 9 mars 2021 à 02:29, Reza Adibnia <re...@futurewei.com> a écrit :
> 
> Hi JB,
> 
> I went through some documents to learn about Apache Way as a committer.
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Fnew-committers-guide.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=wHzc5oXKpuWga0WmJrRNp1Le%2F%2FywKmThVRLni642SME%3D&amp;reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-signing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145796793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=zEXu6uCV04PYrAK3u8mABuQwyiFAjCAM7Tk3JyK60OY%3D&amp;reserved=0
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Finfra.apache.org%2Frelease-publishing.html&amp;data=04%7C01%7Cxun.hu%40futurewei.com%7Ce705311737f243778af508d8e2ba4ff4%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0%7C637508637145806791%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=yTHjwcBVUx7%2Fc8obH%2BMIFEaCrOBU%2BLufSYkJ4hN4Dxk%3D&amp;reserved=0
> 
> To my understanding I can create different branches and commit code to the main branch of incubator-bluemarlin easily. Only having a release requires a process to go through.
> 
> Please let me know if I am correct. I have couple of updates to commit.
> 
> Also, if there is any other document to read as a committer please let me know.
> 
> Best,
> 
> Reza.


Re: commits to incubator-bluemarlin

Posted by Jean-Baptiste Onofre <jb...@nanthrax.net>.
Hi Reza,

To create PR, you can create the branches on a BlueMarlin fork on your own GitHub repo (no need to create branches for PR on BlueMarlin repo).

For release, I will do the first one with you, but it’s not fully ready yet (in terms of artifacts, etc). I have to do some updates still.

Regards
JB

> Le 9 mars 2021 à 02:29, Reza Adibnia <re...@futurewei.com> a écrit :
> 
> Hi JB,
> 
> I went through some documents to learn about Apache Way as a committer.
> 
> https://infra.apache.org/new-committers-guide.html
> https://infra.apache.org/release-signing.html
> https://infra.apache.org/release-publishing.html
> 
> To my understanding I can create different branches and commit code to the main branch of incubator-bluemarlin easily. Only having a release requires a process to go through.
> 
> Please let me know if I am correct. I have couple of updates to commit.
> 
> Also, if there is any other document to read as a committer please let me know.
> 
> Best,
> 
> Reza.