You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yym108 (via GitHub)" <gi...@apache.org> on 2026/09/26 06:14:14 UTC
[PR] [ISSUE #9860] Honor enablePopLog for routine revive logs [rocketmq]
yym108 opened a new pull request, #11236:
URL: https://github.com/apache/rocketmq/pull/11236
### Which Issue(s) This PR Fixes
- Fixes #9860
### Brief Description
Routine POP revive progress messages are written at INFO on every cycle even when `enablePopLog` is false. Gate seven routine log sites in `PopReviveService` with the existing setting, covering start/skip, offsets, checkpoint summaries, completion and idle cycles. This lets the default configuration suppress repetitive progress logging while retaining the diagnostic messages when enabled.
### How Did You Test This Change?
- `PopReviveServiceTest`: all 12 existing tests passed on macOS ARM64 with Zulu JDK 21.
- Reviewed the seven logging guards; the existing tests exercise revive behavior and do not directly assert captured log output.
- Maven's configured Checkstyle/SpotBugs checks and `git diff --check` passed.
- Local JDK 21 execution used JaCoCo 0.8.12, Javassist 3.30.2-GA, Byte Buddy experimental support and JDK module opens. No build configuration changes are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org