[GitHub] [iceberg] chenjunjiedada commented on a change in pull request #2538: Core: Add delete marker metadata column

[GitBox <gi...@apache.org>]

chenjunjiedada commented on a change in pull request #2538:
URL: https://github.com/apache/iceberg/pull/2538#discussion_r637339281



##########
File path: flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java
##########
@@ -191,9 +190,19 @@ public static void assertTableRows(Table table, List<RowData> expected) throws I
 
   public static void assertTableRecords(Table table, List<Record> expected) throws IOException {
     table.refresh();
+

Review comment:
       It is in _expected records_. The extra column is added in `DeleteFileter#fileProjection`.
   
   ```
   private static Schema fileProjection(Schema tableSchema, Schema requestedSchema,
                                          List<DeleteFile> posDeletes, List<DeleteFile> eqDeletes) {
       ...
       // We add it to requiredIds, so that it exists in missingIds when requestedSchema doesn't contain it.
       if (!posDeletes.isEmpty()) {
         requiredIds.add(MetadataColumns.ROW_POSITION.fieldId());
       }
       ....
   
   
       // We append it at the end anyway.
       if (missingIds.contains(MetadataColumns.ROW_POSITION.fieldId())) {
         columns.add(MetadataColumns.ROW_POSITION);
       }
   
       return new Schema(columns);
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org