[GitHub] [pinot] navina commented on pull request #9260: added a default groupid in kafka consumer

[GitBox <gi...@apache.org>]

navina commented on PR #9260:
URL: https://github.com/apache/pinot/pull/9260#issuecomment-1280510554

   @tanmesh sorry about the delay. I was able to verify your patch locally and the integration tests seem to pass now. I think it was some transient failure. 
   
   I think your PR looks good. But its not clear why this change would work with high level consumer implementation. if there is >1 replica, wouldn't we need 3 different group ids ? Which is what happens in pinot controller's `PinotTableIdealStateBuilder.getGroupIdFromRealtimeDataTable()` which attaches the replica id to the group id. So, I am not convinced that this patch will fix the issue with monitoring. Thoughts? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org