You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sujaya Maiyya <su...@citrix.com> on 2014/06/24 12:17:27 UTC
Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful timeout
setting when login to NetScaler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/
-----------------------------------------------------------
Review request for cloudstack, Murali Reddy and Rajesh Battala.
Bugs: 6261
https://issues.apache.org/jira/browse/6261
Repository: cloudstack-git
Description
-------
The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
Diffs
-----
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
Diff: https://reviews.apache.org/r/22927/diff/
Testing
-------
Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
Thanks,
Sujaya Maiyya
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 9, 2014, 4:45 p.m., ASF Subversion and Git Services wrote:
> > Commit e07d0ddabfedad137856c3c9ae7de3a96fe25feb in cloudstack's branch refs/heads/master from Sujaya Maiyya
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e07d0dd ]
> >
> > fixed CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.
> >
I have pushed to master branch. can you close this review request
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review47503
-----------------------------------------------------------
On July 8, 2014, 9:28 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated July 8, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java ff51ef9
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review47503
-----------------------------------------------------------
Commit e07d0ddabfedad137856c3c9ae7de3a96fe25feb in cloudstack's branch refs/heads/master from Sujaya Maiyya
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e07d0dd ]
fixed CLOUDSTACK-6261: remove the forceful timeout setting when login to NetScaler.
- ASF Subversion and Git Services
On July 8, 2014, 9:28 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated July 8, 2014, 9:28 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java ff51ef9
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Sujaya Maiyya <su...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/
-----------------------------------------------------------
(Updated July 8, 2014, 9:28 a.m.)
Review request for cloudstack, Murali Reddy and Rajesh Battala.
Changes
-------
The whitespace errors in the patch are fixed.
Bugs: CLOUDSTACK-6261
https://issues.apache.org/jira/browse/CLOUDSTACK-6261
Repository: cloudstack-git
Description
-------
The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
Diffs (updated)
-----
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java ff51ef9
Diff: https://reviews.apache.org/r/22927/diff/
Testing
-------
Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
Thanks,
Sujaya Maiyya
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Rajesh Battala <ra...@citrix.com>.
> On June 30, 2014, 11:35 a.m., Rajesh Battala wrote:
> > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java, line 2774
> > <https://reviews.apache.org/r/22927/diff/1/?file=615629#file615629line2774>
> >
> > Remove the timeout from this method also
> > This fix should have thrown compilation error as the variable not found.
> >
> > After fixing it Please build the code and post it for review.
> >
This timeout value is dfferent.
Patch looks fine.
I will apply and push it.
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46970
-----------------------------------------------------------
On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 10:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46970
-----------------------------------------------------------
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
<https://reviews.apache.org/r/22927/#comment82567>
Remove the timeout from this method also
This fix should have thrown compilation error as the variable not found.
After fixing it Please build the code and post it for review.
- Rajesh Battala
On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 10:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46973
-----------------------------------------------------------
Unable to apply the patch on latest master.
can you rebase it to latest master and post it for review.
Applying: Forced timeout is not required. The default timeout value of 30 minutes will suffice. Removed timeout in order to support login for Netscaler 10.5 devices.
/home/rajesh/hyperv/.git/rebase-apply/patch:23: trailing whitespace.
_netscalerService.set_credential(_username, _password);
error: patch failed: plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java:293
error: plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java: patch does not apply
Patch failed at 0001 Forced timeout is not required. The default timeout value of 30 minutes will suffice. Removed timeout in order to support login for Netscaler 10.5 devices.
- Rajesh Battala
On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 10:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/#review46972
-----------------------------------------------------------
Ship it!
Ship It!
- Rajesh Battala
On June 24, 2014, 10:23 a.m., Sujaya Maiyya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22927/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 10:23 a.m.)
>
>
> Review request for cloudstack, Murali Reddy and Rajesh Battala.
>
>
> Bugs: CLOUDSTACK-6261
> https://issues.apache.org/jira/browse/CLOUDSTACK-6261
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
>
>
> Diffs
> -----
>
> plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
>
> Diff: https://reviews.apache.org/r/22927/diff/
>
>
> Testing
> -------
>
> Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
>
>
> Thanks,
>
> Sujaya Maiyya
>
>
Re: Review Request 22927: Bugfix CLOUDSTACK-6261: remove the forceful
timeout setting when login to NetScaler.
Posted by Sujaya Maiyya <su...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22927/
-----------------------------------------------------------
(Updated June 24, 2014, 10:23 a.m.)
Review request for cloudstack, Murali Reddy and Rajesh Battala.
Bugs: CLOUDSTACK-6261
https://issues.apache.org/jira/browse/CLOUDSTACK-6261
Repository: cloudstack-git
Description
-------
The NetScaler Resource forces a idle timeout of 100,000 seconds during login. It is best to leave it to the system default which is 30 mins. The timeout has been removed from NetscalerResource in order to support login for Netscaler 10.5 devices.
Diffs
-----
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java 54e5d50
Diff: https://reviews.apache.org/r/22927/diff/
Testing
-------
Timeout was removed and login to the Netscaler devices with the default timeout of 30 minutes was successful. It was tested for Netscaler builds 10.1 and 10.5.
Thanks,
Sujaya Maiyya