[GitHub] [datasketches-cpp] AlexanderSaydakov commented on a diff in pull request #289: Added the extra lower bound functions and test

[GitBox <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #289:
URL: https://github.com/apache/datasketches-cpp/pull/289#discussion_r912081710


##########
tuple/include/tuple_sketch_impl.hpp:
##########
@@ -39,16 +39,30 @@ double tuple_sketch<S, A>::get_estimate() const {
   return get_num_retained() / get_theta();
 }
 
+template<typename S, typename A>
+double tuple_sketch<S, A>::get_lower_bound(uint8_t num_std_devs, uint32_t num_subset_entries) const {
+    if (is_empty()) num_subset_entries = 0 ; // When the sketch is empty we don't keep information for >0 identifiers.

Review Comment:
   num_subset_entries will be set to 0 by line 45 since min(x, 0) == 0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org