[GitHub] [ozone] zhengchenyu commented on pull request #2466: HDDS-5043. Can't list volume accurately in secure mode

[GitBox <gi...@apache.org>]

zhengchenyu commented on pull request #2466:
URL: https://github.com/apache/ozone/pull/2466#issuecomment-890353178


   @jojochuang Yeah, I check it except s3 (I don't know the usage about s3). I also found some wrong usage about ACL,  but it doesn't mater, Because acl check both getUserName and getShortUserName. 
   I only correct the code which will faill the unit test. If you think we need to correct all wrong usage, I will do it.
   Here are all wrong usage:
   
   | wrong usage function| description |
   | --- | ---|
   |  ObjectStore.listVolumesByUser      |   fixed in this PR  |
   |  RpcClient.createVolume                   |   fixed in this PR  |
   | OzoneAclUtil.checkAclRights            |  fixed in this PR   |
   | RpcClient.getAclList                           |  usage for set default acl. Becuase this acl user is owner. So it doesn't matter |
   | OmKeyGenerator.createKey              |  usage for set default acl. Becuase this acl user is owner. So it doesn't matter |
   | s3                                                         | I don't know the usage about s3, so I do not correct it. |
   | BenchMark                                          | I think there is no need to set security mode when benchmark before, so I don't correct it. |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org