You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/04 14:51:30 UTC
Review Request 62065: Added 'mesos agent list' command to CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This command displays the agents in a cluster by
reaching the slaves endpoint of a master. It also
works when Mesos runs in High-Availability Mode.
Diffs
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/62065/diff/1/
Testing
-------
To test with one master:
$ ./bootstrap
$ source activate
$ mesos-cli-tests
To test the command in High-Availability Mode I have:
1. Started ZooKeeper.
2. Started two masters using the flags --zk and --quorum.
3. Started one agent.
4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
5. Checked that the output of 'mesos agent list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/#review184554
-----------------------------------------------------------
FAIL: 'Mesos testes failed to run'
Reviews applied: [61212, 62065]
Logs available here: 'http://mesos-logs.westus.cloudapp.azure.com/mesos-build/review/61211/logs'
- Mesos Reviewbot Windows
On Sept. 4, 2017, 2:51 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62065/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 2:51 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the agents in a cluster by
> reaching the slaves endpoint of a master. It also
> works when Mesos runs in High-Availability Mode.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62065/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags --zk and --quorum.
> 3. Started one agent.
> 4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
> 5. Checked that the output of 'mesos agent list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/#review184520
-----------------------------------------------------------
Bad patch!
Reviews applied: [62065, 61212]
Failed command: python support/apply-reviews.py -n -r 62065
Error:
2017-09-05 09:29:58 URL:https://reviews.apache.org/r/62065/diff/raw/ [8658/8658] -> "62065.patch" [1]
error: patch failed: src/python/cli_new/bin/settings.py:38
error: src/python/cli_new/bin/settings.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/__init__.py:20
error: src/python/cli_new/lib/cli/tests/__init__.py: patch does not apply
error: patch failed: src/python/cli_new/tests/main.py:27
error: src/python/cli_new/tests/main.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19203/console
- Mesos Reviewbot
On Sept. 4, 2017, 4:51 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62065/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 4:51 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the agents in a cluster by
> reaching the slaves endpoint of a master. It also
> works when Mesos runs in High-Availability Mode.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62065/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags --zk and --quorum.
> 3. Started one agent.
> 4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
> 5. Checked that the output of 'mesos agent list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/#review186403
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 61212.
Failed command: `python.exe .\support\apply-reviews.py -n -r 61212`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62065
Relevant logs:
- [apply-review-61212-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62065/logs/apply-review-61212-stdout.log):
```
error: patch failed: src/python/cli_new/lib/cli/util.py:22
error: src/python/cli_new/lib/cli/util.py: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 27, 2017, 12:50 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62065/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:50 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the agents in a cluster by
> reaching the slaves endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62065/diff/3/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/#review186405
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Sept. 27, 2017, 12:50 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62065/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:50 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the agents in a cluster by
> reaching the slaves endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62065/diff/3/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 12:50 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Improved code.
Repository: mesos
Description
-------
This command displays the agents in a cluster by
reaching the slaves endpoint of a master.
Diffs (updated)
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/62065/diff/3/
Changes: https://reviews.apache.org/r/62065/diff/2-3/
Testing
-------
To test with one master:
$ ./bootstrap
$ source activate
$ mesos-cli-tests
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 62065: Added 'mesos agent list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62065/#review186263
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62065`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62065
Relevant logs:
- [apply-review-62065-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62065/logs/apply-review-62065-stdout.log):
```
error: patch failed: src/python/cli_new/bin/settings.py:38
error: src/python/cli_new/bin/settings.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/__init__.py:20
error: src/python/cli_new/lib/cli/tests/__init__.py: patch does not apply
error: patch failed: src/python/cli_new/tests/main.py:27
error: src/python/cli_new/tests/main.py: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 4, 2017, 2:51 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62065/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 2:51 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the agents in a cluster by
> reaching the slaves endpoint of a master.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62065/diff/2/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>